Review main Merged

88299[BUGFIX] Preserve search term when deleting a file

Andreas Kienast CR +2 V +2 Easy +1 −0 updated 02/25/25, 15:47

Commit message

The button for the delete action in the file list now includes a
`data-return-url` attribute that is used to return to after attempting
to delete a file. The generated URL contains the search term, returning
the user to their search result.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 02/20/25, 11:55

  2. core-ci voted on patch set 1 V +1 02/20/25, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74465

  3. Oliver Hader commented on patch set 1 CR +1 V +1 02/21/25, 09:18

    This worked for the buttons in the tiles and list view. However, the delete action from the context menu does not forward the `returnUrl` (might be a different patch).
  4. Benni Mack voted on patch set 1 CR +1 V +1 02/25/25, 15:23

  5. Andreas Kienast commented on patch set 1 CR +2 V +2 02/25/25, 15:35

    Reply

    The whole context menu implementation lacks the broader context (pun not intended) it is used in. This is another issue which needs to be handled separately.
  6. Andreas Kienast merged patch set 2 02/25/25, 15:47