Review main Merged

88304[TASK] Merge workspace hook moveRecord() into DataHandler

Christian Kuhn CR +2 V +2 Hard +205 −248 updated 02/21/25, 14:44

Commit message

The core DataHandler handles lots of workspace related
details already, but still dispatches some handling over
to the workspaces DataHandlerHook. This makes refactoring
and bug fixing way more complicated than it should be since
the hook arguments are often rather unfortunate and can
not keep up with main DataHandler changes.

The patch is a straight inlining of the moveRecord()
workspaces hook handling directly into DataHandler: The main
method is merged into moveRecord(), three helper methods are
moved over as is, except mostly calls to $dataHandler, which
is now $this. The change refrains from adding excessive
refactoring even of obvious details to be easily reviewable.

This allows us to protect various methods that are now "free"
for signature changes, especially moveRecord_raw() is important
in this case. Note the v13 backport will not contain the method
visibility changes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 914

  1. Christian Kuhn uploaded patch set 1 02/21/25, 10:56

  2. core-ci voted on patch set 1 V -1 02/21/25, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74497

  3. Christian Kuhn uploaded patch set 2 V -1 02/21/25, 11:29

  4. core-ci voted on patch set 2 V +1 02/21/25, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74502

  5. Christian Kuhn updated the commit message in patch set 3 V +1 02/21/25, 12:15

  6. Christian Kuhn updated the commit message in patch set 4 02/21/25, 12:19

  7. core-ci voted on patch set 3 V +1 02/21/25, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74503

  8. core-ci voted on patch set 4 V +1 02/21/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74504

  9. Christian Kuhn updated the commit message in patch set 5 V +1 02/21/25, 12:41

  10. core-ci voted on patch set 5 V +1 02/21/25, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74507

  11. Benni Mack voted on patch set 5 CR +1 V +1 02/21/25, 13:39

  12. Stefan Bürk voted on patch set 5 CR +1 V +1 02/21/25, 14:15

  13. Christian Kuhn voted on patch set 5 CR +2 V +2 02/21/25, 14:44

  14. Christian Kuhn merged patch set 6 02/21/25, 14:44