Review main Abandoned

88305[POC][BUGFIX] Toggle bitset of hidden field from IRRE toggle

Andreas Kienast CR 0 V -1 Normal +43 −15 updated 08/26/26, 08:52

Commit message

This patch aims to fix the broken record toggle behavior that pops up in
case a record rendered in IRRE has its own toggle field. It is not
possible to toggle a record by using the IRRE control in that case.

The event handler of such fields is changed to listen to the `change`
event, which is then triggered manually when toggling the control n the
IRRE header.

TODO: Check if there is a less invasive solution.

Review

  • Code review CR 0
  • Verified V -1
    • Garvin Hicking -1
    • core-ci +1 CI

Files 3

Review log 56

  1. Andreas Kienast uploaded patch set 1 02/21/25, 10:58

  2. core-ci voted on patch set 1 V +1 02/21/25, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74498

  3. Georg Ringer commented on patch set 1 03/11/25, 21:21

    wanna finish that? would be awesome! https://forge.typo3.org/issues/96135 is the issue
  4. Garvin Hicking commented on patch set 1 V -1 03/15/25, 00:02

    The good news: This works for me for full "IRRE" relations like in "TCA styleguide inline 1n". Great work! The bad news: This doesn't fix the problem for file references like pages.media. I assume because those IRRE containers have no 'disabled/hidden' inline form element on their own?! I tried: - Assign a few images to pages.media in "Edit page" mode - Collapse all items - Hide a record - Save the page - Reload the page, see everything is as should be - With collapsed items, toggling references works (just as it works now) - Now if I expand one item (so that image metadata appears) and I hide or show a reference and save the record, it will get reset. I attached a GIF to the issue to show this. I hope this can be salvaged maybe?
  5. Benni Mack marked it work in progress 03/22/25, 13:16

  6. Andreas Kienast abandoned the change 08/26/26, 08:52

    Solved in upstream