Review main Merged

88307[TASK] Avoid never true if() in workspace delete hook

Christian Kuhn CR +2 V +2 Easy +0 −11 updated 02/21/25, 14:43

Commit message

BackendUtility::getLiveVersionOfRecord() can never return
a VersionState::DELETE_PLACEHOLDER row. The if() testing
for it can not kick in. This code is probably a left over
that may have been relevant before the "swap" removal
in #92206.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 02/21/25, 12:24

  2. core-ci voted on patch set 1 V +1 02/21/25, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74505

  3. Christian Kuhn updated the commit message in patch set 2 V +1 02/21/25, 12:35

  4. core-ci voted on patch set 2 V +1 02/21/25, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74506

  5. Benni Mack voted on patch set 2 CR +1 V +1 02/21/25, 13:13

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 02/21/25, 14:17

  7. Andreas Kienast voted on patch set 2 CR +1 02/21/25, 14:27

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 02/21/25, 14:43

  9. Christian Kuhn merged patch set 3 02/21/25, 14:43