88308[TASK] Improve description of SYS|reverseProxyHeaderMultiValue
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Mathias Brodala +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- Mathias Brodala +1
- core-ci +1 CI
Issues 1
Files 1
Review log 810
-
Stephan Großberndt uploaded patch set 1 02/21/25, 13:06
-
core-ci voted on patch set 1 V +1 02/21/25, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74508
-
Mathias Brodala commented on patch set 1 02/21/25, 13:40
Generally very useful suggestion. We should also think about merging these or assume "last" as default. (Somewhere else "first" was suggested as default but that can be easily forged by clients) Of course, in a separate change.DefaultConfigurationDescription.yaml:133> Position of the authoritative IP address within the "X-Forwarded-For" header (e.g. "X-Forwarded-For: 1.2.3.4, 2.3.4.5, 3.4.5.6" uses "1.2.3.4" with "first" and "3.4.5.6" with "last") -
Stephan Großberndt uploaded patch set 2
V +103/07/25, 09:18 -
Stephan Großberndt commented on patch set 2 03/07/25, 09:20
Reply
Yes, exactly, I want to do this in a separate change addressing main only.DefaultConfigurationDescription.yaml:133ReplyDone -
core-ci voted on patch set 2 V +1 03/07/25, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75284
-
Mathias Brodala voted on patch set 2 CR +1 V +1 03/07/25, 09:51
-
Markus Klein voted on patch set 2 CR +1 V +1 03/07/25, 09:56
-
Benni Mack voted on patch set 2 CR +2 V +2 03/10/25, 12:08
-
Benni Mack merged patch set 3 03/10/25, 12:08