Review main Merged

88310[TASK] Apply minor DataHandler cleanups

Christian Kuhn CR +2 V +2 Normal +15 −102 updated 02/21/25, 15:03

Commit message

* protected methods need no `@internal` annotation
* $this->enableLogging does not need to be checked
  befole log() since log() does that early.
* Most block comments are outdated or misplaced and
  not really helpful. Let's get rid of them.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Christian Kuhn uploaded patch set 1 02/21/25, 14:00

  2. core-ci voted on patch set 1 V +1 02/21/25, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74513

  3. Christian Kuhn uploaded patch set 2 V +1 02/21/25, 14:49

  4. Christian Kuhn commented on patch set 2 02/21/25, 14:49

    i will merge this as "obvious" rather quickly.
  5. Christian Kuhn updated the commit message in patch set 3 02/21/25, 14:51

  6. core-ci voted on patch set 2 V +1 02/21/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74517

  7. core-ci voted on patch set 3 V +1 02/21/25, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74518

  8. Christian Kuhn voted on patch set 3 CR +2 V +2 02/21/25, 15:03

  9. Christian Kuhn merged patch set 4 02/21/25, 15:03