Review main Merged

88315[TASK] Merge workspace hook deleteAction into DataHandler

Christian Kuhn CR +2 V +2 Normal +95 −120 updated 02/21/25, 20:11

Commit message

This is similar to #106224 and follows the same strategy:
DataHandler handles so many workspace related details
already, that it does not make sense to have the 'delete'
related hook extracted.

Integrating the code to DataHandler unlocks refactoring,
bug fixing, and performance improvements.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 912

  1. Christian Kuhn uploaded patch set 1 02/21/25, 15:23

  2. core-ci voted on patch set 1 V +1 02/21/25, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74522

  3. Christian Kuhn updated the commit message in patch set 2 V +1 02/21/25, 15:39

  4. core-ci voted on patch set 2 V +1 02/21/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74523

  5. Christian Kuhn commented on patch set 2 CR -1 02/21/25, 16:09

    DataHandler.php:5390

    it's probably wise to move the hook *before* the inline ws hook and keep the $recordWasDeleted handling.
  6. Christian Kuhn uploaded patch set 3 CR -1 V +1 02/21/25, 17:53

  7. Christian Kuhn commented on patch set 3 02/21/25, 17:54

    DataHandler.php:5390 Reply

    Done
  8. core-ci voted on patch set 3 V +1 02/21/25, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74532

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 02/21/25, 19:24

  10. Benni Mack voted on patch set 3 CR +1 V +1 02/21/25, 19:56

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 02/21/25, 20:11

  12. Christian Kuhn merged patch set 4 02/21/25, 20:11