Review main Merged

88317[BUGFIX] Better inline child sorting when moving in workspaces

Christian Kuhn CR +2 V +2 Normal +49 −54 updated 02/21/25, 20:07

Commit message

When records having inline foreign field children are moved
in workspaces, the child move placeholder overlays tend to
be created in reverse order.

The fix is to avoid "rogue" code that mixes up copy state.

Existing tests verify better DB state. The offending code
is more obvious with #106224 being done.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 1118

  1. Christian Kuhn uploaded patch set 1 02/21/25, 17:45

  2. core-ci voted on patch set 1 V -1 02/21/25, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74531

  3. Christian Kuhn uploaded patch set 2 V -1 02/21/25, 18:32

  4. Christian Kuhn uploaded patch set 3 02/21/25, 18:36

  5. core-ci voted on patch set 2 V -1 02/21/25, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74533

  6. core-ci voted on patch set 3 V -1 02/21/25, 18:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74534

  7. Christian Kuhn uploaded patch set 4 V -1 02/21/25, 18:54

  8. Christian Kuhn uploaded patch set 5 02/21/25, 19:00

  9. core-ci voted on patch set 4 V -1 02/21/25, 19:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74535

  10. core-ci voted on patch set 5 V +1 02/21/25, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74536

  11. Christian Kuhn updated the commit message in patch set 6 V +1 02/21/25, 19:11

  12. Christian Kuhn updated the commit message in patch set 7 02/21/25, 19:12

  13. core-ci voted on patch set 6 V +1 02/21/25, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74537

  14. core-ci voted on patch set 7 V +1 02/21/25, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74538

  15. Stefan Bürk voted on patch set 7 CR +1 V +1 02/21/25, 19:42

  16. Benni Mack voted on patch set 7 CR +1 V +1 02/21/25, 19:56

  17. Christian Kuhn voted on patch set 7 CR +2 V +2 02/21/25, 20:07

  18. Christian Kuhn merged patch set 8 02/21/25, 20:07