Review main Merged

88327[TASK] Simplify DataHandler->workspaceCannotEditRecord()

Christian Kuhn CR +2 V +2 Normal +16 −43 updated 02/23/25, 16:31

Commit message

Method name and the "false" indicating "ok" are still not
cool, but the method internals can be simplified already.
The method is protected in v14 and now requires the full
record to be handed over instead of optionally the uid only.
All method consumers do that already.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 02/23/25, 11:10

  2. core-ci voted on patch set 1 V +1 02/23/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74588

  3. Anja Leichsenring updated the commit message in patch set 2 V +1 02/23/25, 12:08

  4. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/23/25, 12:09

  5. core-ci voted on patch set 2 V +1 02/23/25, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74589

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 02/23/25, 12:36

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 02/23/25, 16:31

  8. Christian Kuhn merged patch set 3 02/23/25, 16:31