Review main Merged

88328[TASK] Use grid identifier as additional class in page module

Georg Ringer CR +2 V +2 Easy +23 −6 updated 03/07/25, 11:47

Commit message

Having the column and backend layout identifier as additional class in
the grid of the backend makes it possible to build nicer previews for
the editor.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1721

  1. Georg Ringer uploaded patch set 1 02/23/25, 19:55

  2. Georg Ringer commented on patch set 1 02/23/25, 19:55

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/23/25, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74593

  4. Georg Ringer rebased onto patch set 2 V +1 03/02/25, 14:55

  5. core-ci voted on patch set 2 V +1 03/02/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74972

  6. Christian Kuhn commented on patch set 2 03/03/25, 11:48

    reads like a "yeah, why not?" to me. are we sure 'identifier' only contains symbols allowed in html 'class' attribute?
  7. Christian Kuhn commented on patch set 2 03/03/25, 11:49

    Reply

    unresolved: sometimes gerrit tends to set stuff resolved if i don't want to ...
  8. Christian Kuhn voted on patch set 2 CR +1 03/03/25, 11:56

  9. Andreas Kienast voted on patch set 2 CR +1 V +1 03/05/25, 07:11

  10. Benni Mack commented on patch set 2 03/05/25, 14:30

    Reply

    https://www.w3.org/TR/CSS2/syndata.html#characters In CSS, identifiers (including element names, classes, and IDs in selectors) can contain only the characters [a-zA-Z0-9] and ISO 10646 characters U+00A0 and higher, plus the hyphen (-) and the underscore (_); they cannot start with a digit, two hyphens, or a hyphen followed by a digit. Identifiers can also contain escaped characters and any ISO 10646 character as a numeric code (see next item). For instance, the identifier "B&W?" may be written as "B\&W\?" or "B\26 W\3F". "-?[_a-zA-Z]+[_a-zA-Z0-9-]*"
  11. Georg Ringer uploaded patch set 3 CR +1 V +1 03/06/25, 15:21

  12. core-ci voted on patch set 3 V +1 03/06/25, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75227

  13. Benni Mack commented on patch set 3 CR +1 V +1 03/06/25, 17:41

    Reply

    Done
  14. Oli Bartsch commented on patch set 3 03/07/25, 09:27

    For consistency, we should also add the column names in the language comparison mode.

    BackendLayout.php:69

    Since they are used for css classes, I suggest to apply strtolower on them.
  15. Oli Bartsch uploaded patch set 4 CR +1 V +1 03/07/25, 09:36

  16. Oli Bartsch commented on patch set 4 CR +1 V +1 03/07/25, 09:36

    Reply

    Done

    BackendLayout.php:69 Reply

    Done
  17. Georg Ringer voted on patch set 4 CR +1 V +1 03/07/25, 09:37

  18. core-ci voted on patch set 4 V +1 03/07/25, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75285

  19. Benni Mack voted on patch set 4 CR +1 V +1 03/07/25, 10:17

  20. Georg Ringer voted on patch set 4 CR +2 V +2 03/07/25, 11:47

  21. Georg Ringer merged patch set 5 03/07/25, 11:47