88328[TASK] Use grid identifier as additional class in page module
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumn.php+12 −0
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php2+5 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/Column.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+4 −4
Review log 1721
-
Georg Ringer uploaded patch set 1 02/23/25, 19:55
-
Georg Ringer commented on patch set 1 02/23/25, 19:55
This change is ready for review. -
core-ci voted on patch set 1 V +1 02/23/25, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74593
-
Georg Ringer rebased onto patch set 2
V +103/02/25, 14:55 -
core-ci voted on patch set 2 V +1 03/02/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74972
-
Christian Kuhn commented on patch set 2 03/03/25, 11:48
reads like a "yeah, why not?" to me. are we sure 'identifier' only contains symbols allowed in html 'class' attribute? -
Christian Kuhn commented on patch set 2 03/03/25, 11:49
Reply
unresolved: sometimes gerrit tends to set stuff resolved if i don't want to ... -
Christian Kuhn voted on patch set 2 CR +1 03/03/25, 11:56
-
Andreas Kienast voted on patch set 2 CR +1 V +1 03/05/25, 07:11
-
Benni Mack commented on patch set 2 03/05/25, 14:30
Reply
https://www.w3.org/TR/CSS2/syndata.html#characters In CSS, identifiers (including element names, classes, and IDs in selectors) can contain only the characters [a-zA-Z0-9] and ISO 10646 characters U+00A0 and higher, plus the hyphen (-) and the underscore (_); they cannot start with a digit, two hyphens, or a hyphen followed by a digit. Identifiers can also contain escaped characters and any ISO 10646 character as a numeric code (see next item). For instance, the identifier "B&W?" may be written as "B\&W\?" or "B\26 W\3F". "-?[_a-zA-Z]+[_a-zA-Z0-9-]*" -
Georg Ringer uploaded patch set 3
CR +1V +103/06/25, 15:21 -
core-ci voted on patch set 3 V +1 03/06/25, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75227
-
Benni Mack commented on patch set 3 CR +1 V +1 03/06/25, 17:41
Reply
Done -
Oli Bartsch commented on patch set 3 03/07/25, 09:27
For consistency, we should also add the column names in the language comparison mode.BackendLayout.php:69Since they are used for css classes, I suggest to apply strtolower on them. -
Oli Bartsch uploaded patch set 4
CR +1V +103/07/25, 09:36 -
Oli Bartsch commented on patch set 4 CR +1 V +1 03/07/25, 09:36
Reply
DoneBackendLayout.php:69ReplyDone -
Georg Ringer voted on patch set 4 CR +1 V +1 03/07/25, 09:37
-
core-ci voted on patch set 4 V +1 03/07/25, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75285
-
Benni Mack voted on patch set 4 CR +1 V +1 03/07/25, 10:17
-
Georg Ringer voted on patch set 4 CR +2 V +2 03/07/25, 11:47
-
Georg Ringer merged patch set 5 03/07/25, 11:47