Review main Merged

88331[BUGFIX] Provide browse menu key to the integrator

Georg Ringer CR +2 V +2 Easy +1 −0 updated 02/28/25, 08:11

Commit message

If using a menu of type "special = browse", it is really helpful
to know which of the given item names is retrieved. Those are derived
from the provided configuration "items" and needs to be added to the
retrieved database row as well.

The name is now added with the field name "ITEM_STATE" and can be used
when building a menu, e.g. with the menu dataprocessor.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Lina Wolf +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Lina Wolf +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1112

  1. Georg Ringer uploaded patch set 1 02/24/25, 20:37

  2. Georg Ringer commented on patch set 1 02/24/25, 20:38

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/24/25, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74640

  4. Lina Wolf commented on patch set 1 CR +1 02/25/25, 06:55

    Code looks good, still need to test this
  5. Lina Wolf commented on patch set 1 CR 0 02/27/25, 14:47

    Thanks a lot for this solution. I was trying it out with an example site package and the following TypoScript now: ``` page { 10 { dataProcessing { 50 = menu 50 { special = browse as = browseNavigation special { items = index|up|next|prev items.prevnextToSection = 1 index.target = _blank index.fields.title = INDEX } } } } } ``` The ITEM_STATE is now found in `{browseNavigation.0.data.ITEM_STATE}` in my eyes it would make more sense to have it on the meta-level `{browseNavigation.0.ITEM_STATE}` where we also find for example `{browseNavigation.0.data.active}` Also all other variables are written in lowerCamelCase (computed variables) or snake_case (database variables) so that ITEM_STATE has a different case from the others. Is there a reason behind this?
  6. Georg Ringer commented on patch set 1 02/27/25, 20:06

    Reply

    2 reasons: 1st the ITEM_STATE is available also if using a regular TMENU, 2nd generating those primary keys is ugly code which I don't like, generating a fake JSON with tmenu and getting it later back. as it doesn't matter for an integrator to use data, I did go with the nicer solution
  7. Benni Mack voted on patch set 1 CR +1 V +1 02/27/25, 21:15

  8. Garvin Hicking commented on patch set 1 CR +1 V +1 02/27/25, 22:43

    We'll need to note this for the docs, without a changelog rst it may easily get lost. But a dedicated rst feels like overkill. Ping me if this gets merged so we do a docs issue directly (or create one, if you like?)
  9. Lina Wolf commented on patch set 1 CR +1 V +1 02/28/25, 06:01

    Sounds like a valid reason to me. Verified to work fine with my TypoScript example and code looks good
  10. Lina Wolf commented on patch set 1 02/28/25, 06:02

    Reply

    I am planning to write more exessive docs with examples here any way, you can just ping me.
  11. Georg Ringer voted on patch set 1 CR +2 V +2 02/28/25, 08:11

  12. Georg Ringer merged patch set 2 02/28/25, 08:11