Review main Merged

88332[BUGFIX] Provide default configuration for browse menu

Georg Ringer CR +2 V +2 Easy +1 −1 updated 02/28/25, 06:10

Commit message

If no item list is given to a menu using "special = browse", a default
list "index|up|next|prev" should be used instead of failing with
an exception du to a missing check.

Additionally, GU::trimExplode is used to cleanup the code.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Lina Wolf +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Lina Wolf +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Georg Ringer uploaded patch set 1 02/24/25, 20:46

  2. Georg Ringer commented on patch set 1 02/24/25, 20:46

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/24/25, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74641

  4. Lina Wolf commented on patch set 1 CR +1 02/25/25, 06:53

    Code looks fine, didnt try it out yet
  5. Lina Wolf commented on patch set 1 V +1 02/27/25, 14:51

    Verified to work within an example site package
  6. Garvin Hicking voted on patch set 1 CR +1 V +1 02/27/25, 19:36

  7. Benni Mack voted on patch set 1 CR +1 V +1 02/27/25, 21:20

  8. Georg Ringer voted on patch set 1 CR +2 V +2 02/27/25, 22:24

  9. Georg Ringer merged patch set 2 02/27/25, 22:24

  10. Lina Wolf commented on patch set 2 02/28/25, 06:10