Review main Merged

88355[TASK] Avoid loading metadata for files when obtaining the "file" property

TYPO3com CR +2 V +2 Easy +2 −0 updated 03/25/25, 15:07

Commit message

Because FAL loads all files in one folder before applying a pagination
strategy, custom drivers, that make use of heavy i/o tasks may have very
poor performance, especially when dealing with many files in one folder.

By avoiding access to the metadata of a file the response time can still be
reduced substantially.

The default file-list rendering will sort by "file" which is the sys_file
uid but will be obtained via the metadata aspect. This is not necessary as
the file object should be able to return the "name" without using the
metadata aspect.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1015

  1. TYPO3com uploaded patch set 1 02/25/25, 12:10

  2. Josef Glatz commented on patch set 1 CR -1 02/25/25, 12:14

    I think this sentence should be changed, no matter if this patch will by cherry-picked
  3. core-ci voted on patch set 1 V +1 02/25/25, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74677

  4. Philipp Wrann updated the commit message in patch set 2 CR -1 V +1 02/25/25, 18:24

  5. core-ci voted on patch set 2 V +1 02/25/25, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74696

  6. Josef Glatz commented on patch set 2 02/25/25, 21:58

    Reply

    Done
  7. Josef Glatz updated the commit message in patch set 3 V +1 02/25/25, 21:58

  8. core-ci voted on patch set 3 V +1 02/25/25, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74708

  9. Benni Mack commented on patch set 3 03/04/25, 07:09

    how about sorting by name? :)
  10. Benni Mack uploaded patch set 4 V +1 03/25/25, 14:58

  11. Benni Mack voted on patch set 4 CR +1 V +1 03/25/25, 14:58

  12. Andreas Kienast voted on patch set 4 CR +1 V +1 03/25/25, 15:02

  13. core-ci voted on patch set 4 V +1 03/25/25, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76267

  14. Benni Mack voted on patch set 4 CR +2 V +2 03/25/25, 15:07

  15. Benni Mack merged patch set 5 03/25/25, 15:07