Review main Merged

8836[BUGFIX] Properly check disabled versioning within tcemain

Tolleiv Nietsch CR +2 V +2 Easy +3 −3 updated 06/03/13, 20:49

Commit message

Setting $GLOBALS['TCA'][$table]['ctrl']['versioningWS'] = FALSE; isn't
fully working within tcemain because some isset() checks don't
look at the value atm.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Ritter +2
    • Markus Klein +1

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 1 03/13/12, 09:00

    Looks good to me, but someone else must approve no-brainer
    and 4.8
  2. Markus Klein commented on patch set 1 03/13/12, 09:00

    Verified; Looks good to me, but someone else must approve No-brainer.
  3. Philipp Gampe commented on patch set 1 03/13/12, 09:00

    Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 03/13/12, 09:00

  5. Wouter Wolters commented on patch set 1 03/13/12, 09:00

    Looks good to me, but someone else must approve
  6. Steffen Ritter commented on patch set 1 V 0 03/13/12, 09:00

    by team member; Looks good to me, approved
  7. Steffen Ritter merged patch set 1 03/13/12, 09:00