88361[BUGFIX] Handle EXT:scheduler task deserialisation more gracefully
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Lina Wolf +1
- Stefan Bürk +1
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Lina Wolf +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2327
Show 12 earlier messages
-
Garvin Hicking uploaded patch set 1 02/25/25, 20:16
-
core-ci voted on patch set 1 V -1 02/25/25, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74703
-
Garvin Hicking uploaded patch set 2
V -102/25/25, 20:31 -
core-ci voted on patch set 2 V +1 02/25/25, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74704
-
Georg Ringer voted on patch set 2 CR +1 V +1 02/25/25, 20:58
-
Lina Wolf commented on patch set 2 CR -1 V -1 02/26/25, 06:44
This solution would not have solved my problem. A type error is an error, not an exception. I would suggest to catch `catch (\Throwable $e)` or explicitly catch also Type Errors. -
Lina Wolf commented on patch set 2 02/26/25, 06:46
Reply
Thanks a lot for seeing into this problem. However this solution would not have solved my problem. A type error is an error, not an exception. I would suggest to catch `catch (\Throwable $e)` or explicitly catch also Type Errors. -
Garvin Hicking uploaded patch set 3
CR +1V +102/26/25, 09:05 -
Garvin Hicking commented on patch set 3 02/26/25, 09:06
Reply
Thanks a lot for this, you are right of course, good you paid attention to this. I've adapted the code and now added a test case for this, what do you think? -
core-ci voted on patch set 3 V +1 02/26/25, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74735
-
Lina Wolf commented on patch set 3 CR +1 V +1 02/26/25, 09:22
This patch works in my TYPO3 13.4 real project with multiple old scheduler tasks. Code looks good to me -
Lina Wolf commented on patch set 3 02/26/25, 09:23
Reply
Done -
Georg Ringer voted on patch set 3 CR +1 V +1 02/26/25, 10:00
-
Mathias Brodala commented on patch set 3 CR -1 02/26/25, 10:47
TaskSerializer.php:56It is good practice to forward the original exception here. -
Garvin Hicking commented on patch set 3 02/26/25, 11:21
TaskSerializer.php:56Replyhow, do you have an example of this practice? -
Lina Wolf commented on patch set 3 02/26/25, 11:21
TaskSerializer.php:56ReplyIf you are throwing the original exception here the whole backend module will be blocked by the exception and the backend module can then not be used to delete the outdated task. Therefore I would argue that the de-serialization of a possibly outdated task is a rare exception to the general best practice. -
Mathias Brodala commented on patch set 3 02/26/25, 11:25
TaskSerializer.php:56ReplyJust pass the caught exception as 3rd argument to any exception: throw new InvalidTaskException('The serialized task is corrupted: ' . $e->getMessage(), 1740514197, $e); This way an exception trace, if produced somewhere, will be complete. -
Garvin Hicking uploaded patch set 4
CR +1V +102/26/25, 19:11Adjust to also include previous exception -
Garvin Hicking commented on patch set 4 02/26/25, 19:11
TaskSerializer.php:56ReplyThanks. Sounds useful to me, included it. -
core-ci voted on patch set 4 V +1 02/26/25, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74787
-
Christian Kuhn voted on patch set 4 CR +1 V +1 02/27/25, 08:14
-
Lina Wolf voted on patch set 4 CR +1 V +1 02/27/25, 08:26
-
Stefan Bürk voted on patch set 4 CR +1 V +1 02/27/25, 08:51
-
Georg Ringer voted on patch set 4 CR +1 V +1 02/27/25, 09:10
-
Andreas Kienast voted on patch set 4 CR +1 02/27/25, 09:12
-
Garvin Hicking voted on patch set 4 CR +2 V +2 02/27/25, 09:13
-
Garvin Hicking merged patch set 5 02/27/25, 09:46