88362[BUGFIX] Keep DB mount points if moved in a workspace
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1012
-
Georg Ringer uploaded patch set 1 02/26/25, 07:49
-
Georg Ringer commented on patch set 1 02/26/25, 07:49
This change is ready for review. -
core-ci voted on patch set 1 V -1 02/26/25, 07:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74728
-
Philipp Kitzberger voted on patch set 1 V +1 02/26/25, 08:15
-
Georg Ringer uploaded patch set 2
V +102/26/25, 19:41 -
core-ci voted on patch set 2 V +1 02/26/25, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74791
-
Philipp Kitzberger voted on patch set 2 CR +1 V +1 02/26/25, 21:41
-
Benni Mack commented on patch set 2 CR -2 02/26/25, 21:43
sorry, but I added this test on purpose back then in v9. But we've also removed the move pointers in v11, so I need to strongly test this and also look at my notes from 2017 to ensure we're doing the right thing. I will block this for now (temporary, of course) -
Georg Ringer commented on patch set 2 02/27/25, 06:44
Reply
thanks a lot for the -2, just making it green is not the correct way to go and I don't know enough to tell if this is the correct way to go -
Benni Mack commented on patch set 2 CR -1 03/21/25, 21:13
TreeControllerTest.php:575UnresolvedOK. This won't work... this test result shows that "France" is now shown twice... The page "France" is moved from pid=8110 to pid=1700 (where it is shown, according to test test). Now it's shown twice. I don't think this is expected behavior. -
Benni Mack commented on patch set 2 04/08/25, 09:48
I will abandon this patch and ask the author for more feedback -
Benni Mack abandoned the change 04/08/25, 09:48