88363[TASK] Use selectbox to filter link types in broken links result table
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/TypeScript/linkvalidator/linkvalidator.ts2+13 −46
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php+49 −15
- typo3/sysext/linkvalidator/Resources/Private/Language/Module/locallang.xlf+14 −5
- typo3/sysext/linkvalidator/Resources/Private/Partials/CheckForm.fluid.html+11 −12
- typo3/sysext/linkvalidator/Resources/Private/Partials/ReportFilterOptions.fluid.html+7 −35
- typo3/sysext/linkvalidator/Resources/Private/Partials/ReportTable.fluid.html+4 −4
- typo3/sysext/linkvalidator/Resources/Public/JavaScript/linkvalidator.js+1 −1
Review log 3554
Show 1729 earlier messages
-
Jasmina Ließmann uploaded patch set 1 02/26/25, 09:59
-
Jasmina Ließmann updated the commit message in patch set 2 02/26/25, 09:59
-
Jasmina Ließmann marked it work in progress 02/26/25, 09:59
-
Jasmina Ließmann marked it ready for review 02/26/25, 10:02
-
core-ci voted on patch set 1 V +1 02/26/25, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74740
-
core-ci voted on patch set 2 V +1 02/26/25, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74741
-
Jasmina Ließmann updated the commit message in patch set 3
V +102/26/25, 10:42 -
core-ci voted on patch set 3 V +1 02/26/25, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74751
-
Benni Mack marked it work in progress 03/22/25, 14:15
-
Jasmina Ließmann uploaded patch set 4
V +103/23/26, 10:46 -
Jasmina Ließmann uploaded patch set 5 03/23/26, 10:47
-
core-ci voted on patch set 4 V -1 03/23/26, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98451
-
core-ci voted on patch set 5 V -1 03/23/26, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98452
-
Jasmina Ließmann uploaded patch set 6
V -103/23/26, 17:22 -
Jasmina Ließmann uploaded patch set 7 03/23/26, 17:25
-
core-ci voted on patch set 6 V -1 03/23/26, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98516
-
core-ci voted on patch set 7 V -1 03/23/26, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98517
-
Jasmina Ließmann uploaded patch set 8
V -103/24/26, 08:02 -
Jasmina Ließmann uploaded patch set 9 03/24/26, 08:03
-
core-ci voted on patch set 8 V -1 03/24/26, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98541
-
core-ci voted on patch set 9 V -1 03/24/26, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98542
-
Jasmina Ließmann uploaded patch set 10
V -103/24/26, 09:17 -
Jasmina Ließmann uploaded patch set 11 03/24/26, 09:34
-
core-ci voted on patch set 11 V -1 03/24/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98555
-
core-ci voted on patch set 10 V -1 03/24/26, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98552
-
Jasmina Ließmann rebased onto patch set 12
V -103/24/26, 10:54 -
core-ci voted on patch set 12 V -1 03/24/26, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98572
-
Jasmina Ließmann uploaded patch set 13
V -103/24/26, 11:11 -
Jasmina Ließmann uploaded patch set 14 03/24/26, 11:16
-
core-ci voted on patch set 13 V -1 03/24/26, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98574
-
core-ci voted on patch set 14 V -1 03/24/26, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98575
-
Jasmina Ließmann uploaded patch set 15
V -103/24/26, 11:32 -
core-ci voted on patch set 15 V +1 03/24/26, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98576
-
Jasmina Ließmann updated the commit message in patch set 16
V +103/25/26, 09:12 -
Jasmina Ließmann marked it ready for review 03/25/26, 09:12
-
Jasmina Ließmann uploaded patch set 17 03/25/26, 09:21
-
core-ci voted on patch set 16 V +1 03/25/26, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98663
-
core-ci voted on patch set 17 V +1 03/25/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98665
-
Oli Bartsch commented on patch set 17 03/25/26, 09:49
What is the reason for restricting this functionality? We all agree that this module, both in terms of UI and usability, is in a poor state. However, I do not understand how this change improves the situation, aside from removing the ability to perform multiple selections. -
Benjamin Kott commented on patch set 17 03/25/26, 10:04
linkvalidator.ts:48nitpick: empty space -
Jasmina Ließmann uploaded patch set 18
V +103/25/26, 12:47 -
Jasmina Ließmann uploaded patch set 19 03/25/26, 12:48
-
Jasmina Ließmann commented on patch set 18 03/25/26, 12:48
linkvalidator.ts:48ReplyDone -
Jasmina Ließmann commented on patch set 19 03/25/26, 12:55
Reply
The goal is to standardize the user experience. Filtering the entire table based on a single option, rather than multiple ones, aligns with the behavior of other modules—ensuring a consistent user experience. That is why this approach has now been adopted in this module as well. -
core-ci voted on patch set 18 V +1 03/25/26, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98694
-
core-ci voted on patch set 19 V +1 03/25/26, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98695
-
Garvin Hicking commented on patch set 19 03/25/26, 19:17
Reply
Should the "Check of link types" section above then also follow this to replace the "pills" with a dropdown? And maybe we could use a component like in the pagetree for the kebap menu of filtering the tree or the "view cog" in the record list, which open a dropdown where you can tick a checkbox to allow multiselection? This would allow users to still filter for things like "show me internal and external links, but not file links" (which is now not possible anymore). I appreciate the work here because these toggles always felt weird to me and looked like more complexity than they really have (because I directly begin to think in "matrixes" and I always find disabled/enabled states of pills not intuitive). -
Jasmina Ließmann commented on patch set 19 04/01/26, 08:06
Reply
I've reviewed the available display options in EXT:styleguide again, but I can't find anything suitable for displaying multiple selections in an appealing way without having to create something completely new. The pill-shaped layout was an interim step in v13, when I combined both module views onto a single page (https://forge.typo3.org/issues/104145). One could display the pills stacked vertically (as currently shown in the mobile view) or revert to the checkboxes, as before the merge — but both options would take up a lot of space, requiring you to scroll to see the actual results in the table. To solve the space issue, we could move the options/filter settings to a drop-down panel - while that would solve the space issue, I wouldn't prefer it from a usability perspective. @garvin@hick.ing Regarding the "Check of link types" section: At first, I also considered displaying the options there as a selectbox, but from a usability perspective, I think that would be problematic because the user wouldn't be able to see which of the available options have been selected already, and the user would have to submit the form multiple times to check all link types. The results table still includes the "All" option to display more than one selection. Other modules with results tables, such as "Recycler," "Redirects," or "Users" also do not support multiple selections. This change would bring the "Linkvalidator" module in line with this behavior. Personally, I don’t think adding a “View” option that lets you switch between single selection (selectbox) and multiple selection (checkboxes) would be effective, since we’d then face the same display and space issues with the checkboxes again. And yes, the module needs further adjustments. -
Jasmina Ließmann commented on patch set 19 04/08/26, 09:50
Reply
I'm marking this discussion as "resolved" because there hasn't been any feedback for 7 days. -
Garvin Hicking commented on patch set 19 04/08/26, 12:54
Reply
Sorry, was in featurefreeze-mode. Also I don't really authoritatively know how to deal with this. So yeah please do go ahead!! -
Benni Mack commented on patch set 19 CR +1 V +1 04/15/26, 15:55
let's get this patch in, please. This module obviously needs more love apart from this patch, and we're lacking further concepts, we'd need to consider with a UX person in v15. -
Garvin Hicking voted on patch set 19 CR +1 V +1 04/15/26, 17:56
-
Jasmina Ließmann voted on patch set 19 CR +2 V +2 04/15/26, 21:01
-
Jasmina Ließmann merged patch set 20 04/15/26, 21:02