88375[TASK] Remove column NEWid in DB table sys_log
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 3
Files 6
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php2+17 −21
- typo3/sysext/belog/Classes/Domain/Model/LogEntry.php+0 −16
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php2+19 −22
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+4 −7
- typo3/sysext/core/ext_tables.sql+0 −1
- typo3/sysext/lowlevel/Classes/Command/ListSysLogCommand.php3+0 −1
Review log 1521
-
Christian Kuhn uploaded patch set 1 02/26/25, 20:28
-
core-ci voted on patch set 1 V -1 02/26/25, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74795
-
Christian Kuhn uploaded patch set 2
V -102/26/25, 20:49 -
core-ci voted on patch set 2 V +1 02/26/25, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74796
-
Christian Kuhn updated the commit message in patch set 3
V +102/26/25, 21:07 -
Christian Kuhn updated the commit message in patch set 4 02/26/25, 21:10
-
core-ci voted on patch set 3 V +1 02/26/25, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74798
-
core-ci voted on patch set 4 V +1 02/26/25, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74799
-
Benni Mack voted on patch set 4 CR +1 V +1 02/26/25, 21:23
-
Stefan Bürk commented on patch set 4 02/26/25, 21:37
BackendUserAuthentication.php:1807```suggestion Connection::PARAM_INT, ``` workspace is a INT(11) field, so last type should be *::PARAM_INT. Was wrong - or better to say not really correct. -
Garvin Hicking commented on patch set 4 02/26/25, 22:56
ListSysLogCommand.php:108IMO we should note DB changes in a point release with a changelog entry, and consumers of this command (not internal) who might parse the output should take notice of this structural change, what do you think? -
Georg Ringer updated the commit message in patch set 5
CR +1V +102/27/25, 06:51 -
Georg Ringer commented on patch set 5 02/27/25, 06:52
it does not only avoid the column, it removes it ^^ListSysLogCommand.php:108Replyin main this is fine, the backport should not touch that, correct -
core-ci voted on patch set 5 V +1 02/27/25, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74817
-
Christian Kuhn commented on patch set 5 03/01/25, 23:46
PasswordReset.php:478ReplyDoneBackendUserAuthentication.php:1807ReplyDoneListSysLogCommand.php:108Replyalright. i'll changes this in v13 with a hack in 'arrayToLogString()': "$str .= 'NEWid: ' . LF;" before the return. -
Christian Kuhn uploaded patch set 6
V +103/01/25, 23:49 -
core-ci voted on patch set 6 V +1 03/01/25, 23:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74947
-
Georg Ringer commented on patch set 6 CR +2 V +2 03/02/25, 13:37
@lolli@schwarzbu.ch feel free to merge and create the backport for v13 -
Anja Leichsenring voted on patch set 6 CR +1 V +1 03/03/25, 10:31
-
Christian Kuhn voted on patch set 6 CR +2 V +2 03/03/25, 11:05
-
Christian Kuhn merged patch set 7 03/03/25, 11:06
PasswordReset.php:478