Review main Merged

88375[TASK] Remove column NEWid in DB table sys_log

Christian Kuhn CR +2 V +2 Normal +40 −68 updated 03/03/25, 11:06

Commit message

Column NEWid in table sys_log plays a useless role: It
reflects temporary information that can never be replayed
and has no impact at all. It is not systematically used
by DataHandler, and it is never actively used in ext:belog.
The only truly useful information within DataHandelr is
$correlationId, and this one is automatically handled, which
can be helpful when debugging.

The patch removes the DB column and its handling.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 1521

  1. Christian Kuhn uploaded patch set 1 02/26/25, 20:28

  2. core-ci voted on patch set 1 V -1 02/26/25, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74795

  3. Christian Kuhn uploaded patch set 2 V -1 02/26/25, 20:49

  4. core-ci voted on patch set 2 V +1 02/26/25, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74796

  5. Christian Kuhn updated the commit message in patch set 3 V +1 02/26/25, 21:07

  6. Christian Kuhn updated the commit message in patch set 4 02/26/25, 21:10

  7. core-ci voted on patch set 3 V +1 02/26/25, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74798

  8. core-ci voted on patch set 4 V +1 02/26/25, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74799

  9. Benni Mack voted on patch set 4 CR +1 V +1 02/26/25, 21:23

  10. Stefan Bürk commented on patch set 4 02/26/25, 21:37

    PasswordReset.php:478

    ```suggestion Connection::PARAM_INT, ``` Types not aligned to provided fields, one PARAM_STR needs to be removed. Not breaking, but confusing. The last parameter needs to be Connection::PARAM_INT

    BackendUserAuthentication.php:1807

    ```suggestion Connection::PARAM_INT, ``` workspace is a INT(11) field, so last type should be *::PARAM_INT. Was wrong - or better to say not really correct.
  11. Garvin Hicking commented on patch set 4 02/26/25, 22:56

    ListSysLogCommand.php:108

    IMO we should note DB changes in a point release with a changelog entry, and consumers of this command (not internal) who might parse the output should take notice of this structural change, what do you think?
  12. Georg Ringer updated the commit message in patch set 5 CR +1 V +1 02/27/25, 06:51

  13. Georg Ringer commented on patch set 5 02/27/25, 06:52

    it does not only avoid the column, it removes it ^^

    ListSysLogCommand.php:108 Reply

    in main this is fine, the backport should not touch that, correct
  14. core-ci voted on patch set 5 V +1 02/27/25, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74817

  15. Christian Kuhn commented on patch set 5 03/01/25, 23:46

    PasswordReset.php:478 Reply

    Done

    BackendUserAuthentication.php:1807 Reply

    Done

    ListSysLogCommand.php:108 Reply

    alright. i'll changes this in v13 with a hack in 'arrayToLogString()': "$str .= 'NEWid: ' . LF;" before the return.
  16. Christian Kuhn uploaded patch set 6 V +1 03/01/25, 23:49

  17. core-ci voted on patch set 6 V +1 03/01/25, 23:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74947

  18. Georg Ringer commented on patch set 6 CR +2 V +2 03/02/25, 13:37

    @lolli@schwarzbu.ch feel free to merge and create the backport for v13
  19. Anja Leichsenring voted on patch set 6 CR +1 V +1 03/03/25, 10:31

  20. Christian Kuhn voted on patch set 6 CR +2 V +2 03/03/25, 11:05

  21. Christian Kuhn merged patch set 7 03/03/25, 11:06