Review main Merged

88378[TASK] Remove unused and broken `FormEngine.getFormElement()`

Andreas Kienast CR +2 V +2 Easy +1 −33 updated 02/27/25, 09:09

Commit message

The FormEngine method `FormEngine.getFormElement()` was absolutely
bonkers. The method accepted an optional field name and had the
following handling:

* if the field name was not passed, return the `form` tag as a jQuery
  object
* if the field name was passed, check if the field is an actual element
  within the form. If true, the form is returned as a jQuery object.
  Otherwise, nothing was returned and `alert()` was called.

This method is not used anymore since #91486 and is also not used in
any public extension that supports current LTS versions. Therefore, the
method has been removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 02/27/25, 08:59

  2. Benni Mack updated the commit message in patch set 2 02/27/25, 09:01

  3. Benni Mack voted on patch set 2 CR +1 V +1 02/27/25, 09:01

  4. core-ci voted on patch set 1 V +1 02/27/25, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74821

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 02/27/25, 09:08

  6. core-ci voted on patch set 2 V +1 02/27/25, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74822

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 02/27/25, 09:09

  8. Andreas Kienast merged patch set 3 02/27/25, 09:09