Review main Abandoned

88383[WIP][TASK] Rip & tear FormEngine.setSelectOptionFromExternalSource

Andreas Kienast CR 0 V 0 Hard +156 −121 updated 02/28/25, 14:30

Commit message

The method `FormEngine.setSelectOptionFromExternalSource` is another
monster on its own. It is responsible for managing the value and UI
state of `group` and `selectMultipleSideBySide` fields.

While one may merge the rather similar behavior into a single method,
this is actually not a good idea. The main reaon is that handling that
is suited for either of both field types is executed in every case (and
dead code in any of both cases).

For example: a `selectMultipleSideBySide` has, as the name suggests, the
nature of containing multiple values. It does not make sense to check
whether multiple values are allowed in such case. OTOH, `group` fields
don't have to deal with disabling options in an "oppsite" field or
so-called "exclusive values".

This patch tries to separate the method into smaller chunks and place it
where it's better suited.

TODO:
* Check how external updates, e.g. from Element Browser, may be handled
  without needing an event for one single case.

Review

  • Code review CR 0
  • Verified V 0

Files 6

Review log 47

  1. Andreas Kienast uploaded patch set 1 02/27/25, 13:17

  2. core-ci voted on patch set 1 V +1 02/27/25, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74833

  3. Andreas Kienast uploaded patch set 2 V +1 02/27/25, 15:44

  4. core-ci voted on patch set 2 V -1 02/27/25, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74841

  5. Andreas Kienast uploaded patch set 3 V -1 02/27/25, 15:53

  6. core-ci voted on patch set 3 V +1 02/27/25, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74842

  7. Andreas Kienast abandoned the change 02/28/25, 14:30

    Needs another approach