Review main Merged

88385[BUGFIX] Fix race condition between hotkey usage and registration

Benjamin Franzke CR +2 V +2 Easy +4 −2 updated 02/27/25, 14:49

Commit message

Ensure that the scoped hotkey map `all` is available instantly, to be
able to be used during early keydown events, even if no hotkey has been
registered yet.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benjamin Franzke uploaded patch set 1 02/27/25, 13:52

  2. Benjamin Kott voted on patch set 1 CR +1 V +1 02/27/25, 13:54

  3. core-ci voted on patch set 1 V +1 02/27/25, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74836

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 02/27/25, 14:01

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 02/27/25, 14:24

  6. Benjamin Franzke merged patch set 2 02/27/25, 14:49