Review main Abandoned

88392[WIP][TASK] Add password meter to the password field

Georg Ringer CR 0 V -1 Normal +120 −2 updated 09/08/25, 05:25

Commit message

Give editors & admins instant feedback about the validation of
a password by checking it with ajax against the policies.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 5

Review log 1012

  1. Georg Ringer uploaded patch set 1 02/28/25, 07:30

  2. Benjamin Franzke commented on patch set 1 02/28/25, 07:34

    password-element.ts:71

    Let's never send passwords *anywhere* before a user explicitly asks us to do so. This is very questionable from a security perspective.
  3. Andreas Kienast commented on patch set 1 02/28/25, 07:35

    password-element.ts:64

    Please do not react on each input event. This will stack up and may lead to incorrect values as the order of the responses may not equal the order of sent requests. Better use `DebounceEvent` for this!

    password-element.ts:66 Unresolved

    I'd rather see a web component here.
  4. core-ci voted on patch set 1 V -1 02/28/25, 07:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74867

  5. Georg Ringer commented on patch set 1 02/28/25, 07:49

    This change is ready for review.

    password-element.ts:64 Reply Unresolved

    see slack: I really would need some help for the FE part. I am pretty sure this can be improved a lot, also for icon positioning, etc can you help?
  6. Georg Ringer commented on patch set 1 02/28/25, 08:13

    password-element.ts:71 Reply Unresolved

    would it be ok for you to change that to optin via settings? I really find the current implementation bad having no feedback at all @ben@bnf.dev
  7. Simon Schaufelberger commented on patch set 1 02/28/25, 10:00

    I would use a pure js check without the need of php.
  8. Georg Ringer commented on patch set 1 03/02/25, 13:41

    Reply Unresolved

    @simonschaufi+typo3@gmail.com that is not possible for more complex rules. @ben@bnf.dev I see there 2 options in the core and would be great to get some feedback: a) Provide a feature flag in TYPO3_CONF_VARS b) Provide a new button below the rules which can be used to trigger the check What do you think?
  9. Benni Mack marked it work in progress 03/22/25, 14:14

  10. Georg Ringer uploaded patch set 2 V -1 06/07/25, 19:58

  11. core-ci voted on patch set 2 V -1 06/07/25, 20:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80048

  12. Georg Ringer abandoned the change 09/08/25, 05:25