Review main Merged

88397[BUGFIX] Fix pagination of reactions and webhooks module

Oli Bartsch CR +2 V +2 Easy +14 −14 updated 03/03/25, 08:28

Commit message

This fixes the pagination implementations, used
in the reactions and the webhooks module, which
are basically the same code base.

When filtering the "all count" is now properly
calculated preventing that the pagination is
always displayed even if there are only a
subset of records available.

The pagination refresh button now actually
refreshes the current paginated page.

A duplicated records object is removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 67

  1. Oli Bartsch uploaded patch set 1 02/28/25, 10:18

  2. core-ci voted on patch set 1 V +1 02/28/25, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74887

  3. Benni Mack voted on patch set 1 CR +1 V +1 02/28/25, 20:49

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 02/28/25, 20:56

  5. Christian Kuhn voted on patch set 1 CR +1 03/02/25, 00:32

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 03/03/25, 08:28

  7. Oli Bartsch merged patch set 2 03/03/25, 08:28