Review main Merged

88398[BUGFIX] Handle failed record duplication attempt

Oli Bartsch CR +2 V +2 Easy +24 −13 updated 03/02/25, 13:25

Commit message

Duplication of a record in FormEngine might
fail, e.g. for webhooks, as the identifier is
defined as unique and therefore resulting in
an SQL error on copy.

In EditDocumentController it is now properly
checked, wether the duplication attempt
worked and otherwise displays a
corresponding flash message.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 02/28/25, 10:43

  2. core-ci voted on patch set 1 V +1 02/28/25, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74889

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 02/28/25, 19:35

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 03/02/25, 01:13

  5. Georg Ringer voted on patch set 1 CR +2 V +2 03/02/25, 13:25

  6. Georg Ringer merged patch set 2 03/02/25, 13:25