Review main Merged

88400[BUGFIX] Handle NULL as JSON value

Oli Bartsch CR +2 V +2 Easy +10 −4 updated 03/02/25, 13:27

Commit message

By default a TCA type "json" field,
corresponding database column is
generated as nullable with NULL as
default value.

When not setting a TCA default value,
new records therefore might be created
with NULL as value, which no longer
fails with a TypeError as we now also
handle NULL in DataHandler.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 02/28/25, 11:10

  2. core-ci voted on patch set 1 V +1 02/28/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74892

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 02/28/25, 20:50

    Please also see https://review.typo3.org/c/Packages/TYPO3.CMS/+/88416 as a similar side-effect, I recognize now
  4. Christian Kuhn voted on patch set 1 CR +1 V +1 03/02/25, 00:35

  5. Georg Ringer voted on patch set 1 CR +2 V +2 03/02/25, 13:27

  6. Georg Ringer merged patch set 2 03/02/25, 13:27