Review main Abandoned

88401[TASK] Hide duplication button for reactions and webhooks

Oli Bartsch CR 0 V 0 Easy +2 −0 updated 03/24/25, 15:39

Commit message

Duplicating reactions and webhooks does not
work due the fact that they both contain a
UUID field, which can not be copied. There
is currently no solution for this in the
DataHandler.

Therefore, the button is disabled for now
to prevent exceptions on duplication attempts.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 910

  1. Oli Bartsch uploaded patch set 1 02/28/25, 11:19

  2. core-ci voted on patch set 1 V +1 02/28/25, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74893

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 02/28/25, 20:43

    I think having the ability to duplicate specifically reactions and webhooks is something people would like to do, for just "minor" differences in a URI or so. Would a datahandler hook for this maybe work out, so that a dummy unique ID is added to the unique field, and after the copy is persisted, a fresh one could be generated? So the copy operation would be allowed to work, and the "proper" UUID generation (which is usually part of the FormEngine form population, right?) could be done afterwards...?
  4. Christian Kuhn commented on patch set 1 CR -1 03/02/25, 01:08

    this feels unfinished and does not work for me. first: the 'duplicate' button is 'off' by default and can be enabled 'globally' with user ts 'options.showDuplicate = 1'. when i set this, and apply the patch, and edit a reaction, the duplicate button is still shown. when i do not set 'options.showDuplicate = 1', but only set 'options.showDuplicate.sys_reaction = 1' in a users userTS, and apply the patch, then the duplicate button is *also* still shown. and apart from that, i think we should finally see if we can finish https://review.typo3.org/c/Packages/TYPO3.CMS/+/81929 instead to actually *allow* duplication and create a new uuid when necessary. what do you think?

    Reply

    there is a patch that tries to fix this bug in DataHandler pending for quite a while already. it should be finished. https://review.typo3.org/c/Packages/TYPO3.CMS/+/81929
  5. Oli Bartsch commented on patch set 1 03/03/25, 08:41

    Reply

    > when i set this, and apply the patch, and edit a reaction, the duplicate button is still shown. This is not the intended behaviour and I can't reproduce this. Specific table settings overrides the global setting. Depending on loading order one can still enable the button for the tables - sure. Ideally, finishing the UUID implementation would be the best solution. Unfortunately, I’m currently unable to dedicate time to this as I’m focused on other areas. Perhaps you could help with this?
  6. Christian Kuhn commented on patch set 1 03/03/25, 10:14

    Reply

    i can test again, but was kinda sure i didn't get it wrong. in any case, this patch is a half baked solution. i'm time constrained as well and will not be able to finish the uuid change myselfs very soon.
  7. Oli Bartsch commented on patch set 1 03/03/25, 10:47

    Reply

    I totally understand the need for UUID functionality, but in the meantime, we should focus on preventing UX components from triggering exceptions. While finishing the UUID implementation is ideal, we could at least address the issue with the duplicate button to improve the situation until we find the time to implement it. Thoughts?
  8. Christian Kuhn commented on patch set 1 03/03/25, 11:42

    Reply

    well, the change did not improve the situation according to my testing. let's maybe have a quick talk?
  9. Oli Bartsch commented on patch set 1 03/03/25, 16:57

    Reply Unresolved

    Yes, absolutely!
  10. Benni Mack abandoned the change 03/24/25, 15:39