Review main Merged

88402[TASK] Simplify DataHandler->doesRecordExist_pageLookUp()

Christian Kuhn CR +2 V +2 Normal +38 −24 updated 03/03/25, 12:32

Commit message

The amount of repeated queries created by the permission
check related DataHandler methods is stunning. They tend
to do the same thing over and over again with only minor
changes.

This change is a preparation patch to make the database
load of the related methods collapse: We check the page
permission access in PHP instead of within a query. This
allows us to refactor the calling code to hand over the
page row instead of fetching it every time.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Christian Kuhn uploaded patch set 1 02/28/25, 12:40

  2. core-ci voted on patch set 1 V +1 02/28/25, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74895

  3. Christian Kuhn rebased onto patch set 2 V +1 03/03/25, 10:15

  4. core-ci voted on patch set 2 V +1 03/03/25, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74998

  5. Christian Kuhn uploaded patch set 3 V +1 03/03/25, 11:14

  6. Stefan Bürk voted on patch set 3 CR +1 V +1 03/03/25, 11:17

  7. core-ci voted on patch set 3 V +1 03/03/25, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75004

  8. Benni Mack voted on patch set 3 CR +1 V +1 03/03/25, 12:26

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 03/03/25, 12:32

  10. Christian Kuhn merged patch set 4 03/03/25, 12:32