Review main Merged

88406[TASK] FormEngine: Avoid unneeded regexes when parsing exclusive values

Andreas Kienast CR +2 V +2 Easy +10 −13 updated 03/02/25, 09:47

Commit message

The method `FormEngine.setSelectOptionFromExternalSource()` takes care
of so-called "exclusive values" – values, that are mutually exclusive in
usage, as e.g. seen in `pages.fe_group`.

Exclusive values are passed as a comma-separated value. When an incoming
value is checked for existence in this CSV, multiple regular expressions
are composed, which is quite an overhead.

Exclusive values are now passed as an array, where value existence can
easily be checked via `.includes()`.

The method signature of `setSelectOptionFromExternalSource` is changed
in this patch. The code search didn't reveal usage in any TER extension,
therefore this is not considered being a breaking change.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. Andreas Kienast uploaded patch set 1 02/28/25, 14:55

  2. core-ci voted on patch set 1 V -1 02/28/25, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74904

  3. Andreas Kienast uploaded patch set 2 V -1 02/28/25, 15:08

  4. core-ci voted on patch set 2 V +1 02/28/25, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74906

  5. Garvin Hicking updated the commit message in patch set 3 V +1 02/28/25, 21:54

  6. Garvin Hicking voted on patch set 3 CR +1 V +1 02/28/25, 21:56

  7. core-ci voted on patch set 3 V +1 02/28/25, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74924

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 03/02/25, 01:22

  9. Andreas Kienast voted on patch set 3 CR +2 V +2 03/02/25, 09:37

  10. Andreas Kienast merged patch set 4 03/02/25, 09:47