Review main Merged

88407[TASK] Remove unused `FormEngine.legacyFieldChangedCb()`

Andreas Kienast CR +2 V +2 Easy +2 −13 updated 03/02/25, 13:23

Commit message

The method `FormEngine.legacyFieldChangedCb()` was used back in the days
by legacy FormEngine which passed a callback function via the PHP
property `TBE_EDITOR_fieldChanged_func`. Later on, the configuration
`TYPO3.settings.FormEngine.legacyFieldChangedCb` was used.

Neither TYPO3 core, nor any extension available in TER use this relict.
It is therefore safe to assume we can remove this method without being a
breaking change.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 911

  1. Andreas Kienast uploaded patch set 1 02/28/25, 15:03

  2. core-ci voted on patch set 1 V +1 02/28/25, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74905

  3. Benni Mack voted on patch set 1 CR +1 V +1 02/28/25, 20:47

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 02/28/25, 22:01

  5. Christian Kuhn voted on patch set 1 CR +1 V +1 03/02/25, 01:20

  6. Andreas Kienast uploaded patch set 2 CR +1 V +1 03/02/25, 09:48

  7. Andreas Kienast commented on patch set 2 03/02/25, 09:49

    Just a rebase...
  8. core-ci voted on patch set 2 V +1 03/02/25, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74961

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 03/02/25, 10:08

  10. Georg Ringer voted on patch set 2 CR +2 V +2 03/02/25, 13:23

  11. Georg Ringer merged patch set 3 03/02/25, 13:23