Review main Merged

88410[BUGFIX] Streamline language switch in columns only mode

Oli Bartsch CR +2 V +2 Hard +163 −153 updated 03/03/25, 09:55

Commit message

In "columns only" mode, only a subset of available fields
are displayed for a record. Those views are usually used
for bulk editing or editing just specific context related
fields, e.g. the pages seo data. Those views are not intended
for localization as this does not work with "columns only".

Therefore, the language switch does no longer propose to
translate the record to another language, when in "columns
only" mode.

But: The language switch does now respect the "columns
only" config for existing records. This means switching
to a translation keeps the configured fields.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Daniel Gohlke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Daniel Gohlke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Oli Bartsch uploaded patch set 1 02/28/25, 16:26

  2. core-ci voted on patch set 1 V -1 02/28/25, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74911

  3. Oli Bartsch uploaded patch set 2 V -1 02/28/25, 16:56

  4. core-ci voted on patch set 2 V +1 02/28/25, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74916

  5. Mathias Brodala updated the commit message in patch set 3 V +1 02/28/25, 19:26

  6. core-ci voted on patch set 3 V +1 02/28/25, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74920

  7. Daniel Gohlke voted on patch set 3 CR +1 02/28/25, 19:54

  8. Daniel Gohlke voted on patch set 3 V +1 02/28/25, 20:14

  9. Garvin Hicking commented on patch set 3 CR +1 V +1 03/03/25, 09:37

    Voting for that it works and code logic looks sane - I can't tell about the possible editor/workflow implications of it and if there's a drawback
  10. Oli Bartsch voted on patch set 3 CR +2 V +2 03/03/25, 09:55

  11. Oli Bartsch merged patch set 4 03/03/25, 09:55