88418[BUGFIX] Improve exception handling for incorrect YAML syntax
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Mathias Brodala +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Mathias Brodala +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Scripts/runTests.sh+1 −1
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoader.php2+10 −2
- typo3/sysext/core/Tests/Functional/Configuration/Loader/Fixtures/InvalidYamlFiles/LoadEmptyYaml.yamlnew+0 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/Fixtures/InvalidYamlFiles/LoadInvalidYaml.yamlnew+16 −0
- typo3/sysext/core/Tests/Functional/Configuration/Loader/YamlFileLoaderTest.php+25 −0
Review log 1216
-
Lina Wolf uploaded patch set 1 03/01/25, 08:20
-
core-ci voted on patch set 1 V -1 03/01/25, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74941
-
Lina Wolf uploaded patch set 2
V -103/01/25, 08:33 -
core-ci voted on patch set 2 V -1 03/01/25, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74942
-
Lina Wolf uploaded patch set 3
V -103/01/25, 11:09 -
core-ci voted on patch set 3 V +1 03/01/25, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74943
-
Garvin Hicking commented on patch set 3 CR +1 V +1 03/01/25, 12:42
You refer to the "normal" exception wiki-style docs, right? -
Lina Wolf commented on patch set 3 03/01/25, 13:42
Reply
Yes -
Mathias Brodala commented on patch set 3 03/03/25, 07:48
YamlFileLoader.php:82I know the wording is just a copy from below but it does not make any sense. One does not "parse something into syntax". Better wording: > YAML file "..." has syntax errors: ... -
Lina Wolf commented on patch set 4
CR +1V +103/03/25, 07:52Published edit on patch set 3. -
Lina Wolf commented on patch set 4 03/03/25, 07:52
YamlFileLoader.php:82ReplyI changed the text of both error messages. -
Mathias Brodala voted on patch set 4 CR +1 V +1 03/03/25, 07:53
-
core-ci voted on patch set 4 V +1 03/03/25, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74991
-
Garvin Hicking voted on patch set 4 CR +1 V +1 03/03/25, 08:03
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 03/04/25, 12:37
-
Benjamin Franzke merged patch set 5 03/04/25, 12:45