Review 13.4 Merged

88429[TASK] Remove unused `FormEngine.legacyFieldChangedCb()`

Andreas Kienast CR +2 V +2 Easy +2 −13 updated 03/02/25, 16:03

Commit message

The method `FormEngine.legacyFieldChangedCb()` was used back in the days
by legacy FormEngine which passed a callback function via the PHP
property `TBE_EDITOR_fieldChanged_func`. Later on, the configuration
`TYPO3.settings.FormEngine.legacyFieldChangedCb` was used.

Neither TYPO3 core, nor any extension available in TER use this relict.
It is therefore safe to assume we can remove this method without being a
breaking change.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Andreas Kienast uploaded patch set 1 03/02/25, 15:50

  2. core-ci voted on patch set 1 V +1 03/02/25, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74975

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 03/02/25, 16:02

  4. Andreas Kienast merged patch set 2 03/02/25, 16:03