Review main Merged

88430[TASK] Add Tests for SetupService::createBackendUserGroups

Lina Wolf CR +2 V +2 Normal +124 −20 updated 03/03/25, 13:16

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1214

  1. Lina Wolf uploaded patch set 1 03/02/25, 16:09

  2. core-ci voted on patch set 1 V +1 03/02/25, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74976

  3. Garvin Hicking commented on patch set 1 03/02/25, 17:02

    Maybe we could save some resources by running identical code executions with the full set of a csv expectancy instead of only specific columns? I do see benefit of having this separated, but setting up a new instance multiple times with the same input has a cost?
  4. Lina Wolf commented on patch set 1 03/02/25, 17:07

    Reply

    I at first tried to check all permissions at once, however I found the test results hard to read and understand if a test was failing. However I already pinged Stefan Bürk about these tests. Lets see what is his opinion on this?
  5. Garvin Hicking commented on patch set 1 03/02/25, 17:10

    Reply

    you can give the assertions distinct output keys to indicate the specific failure reason? Not blocking this, I would just prefer to not have too much redundancy if it's possible.
  6. Christian Kuhn commented on patch set 1 03/03/25, 12:43

    Reply

    i tend to keep the first two tests and combine the other six into one. i'll see if this works out and will push.
  7. Christian Kuhn commented on patch set 1 03/03/25, 12:48

    SetupServiceTest.php:157

    wrong filename used here and ext:dashboard is not loaded.
  8. Christian Kuhn commented on patch set 1 03/03/25, 12:56

    Reply

    ok, let's combine the "short" things, but keep the "long" values separated. that will probably simplify maintenance and is more easy to read.

    SetupServiceTest.php:157 Reply

    Done
  9. Christian Kuhn uploaded patch set 2 V +1 03/03/25, 12:57

  10. Christian Kuhn voted on patch set 2 CR +1 V +1 03/03/25, 12:57

  11. core-ci voted on patch set 2 V +1 03/03/25, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75016

  12. Garvin Hicking voted on patch set 2 CR +1 V +1 03/03/25, 13:13

  13. Christian Kuhn voted on patch set 2 CR +2 V +2 03/03/25, 13:16

  14. Christian Kuhn merged patch set 3 03/03/25, 13:16