Review main Merged

88431[BUGFIX] Create file mount for setup:begroups:default

Lina Wolf CR +2 V +2 Normal +69 −2 updated 03/27/25, 21:24

Commit message

If none exists, create a file mount for "1:/user_upload/". File storage
1 is automatically created during setup and points to
`public/fileadmin`. The `public/fileadmin/user_upload` directory is also
created automatically.

This ensures that users of the automatically-created groups can use the
file list module. They already have access but cannot use it due to the
missing file mount. It also allows them to upload images in content elements like "Text & Media".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1925

  1. Lina Wolf uploaded patch set 1 03/03/25, 05:25

  2. Lina Wolf marked it work in progress 03/03/25, 05:25

  3. core-ci voted on patch set 1 V +1 03/03/25, 05:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74988

  4. Lina Wolf uploaded patch set 2 V +1 03/03/25, 16:22

  5. Lina Wolf commented on patch set 2 03/03/25, 16:23

    This change is ready for review.
  6. core-ci voted on patch set 2 V +1 03/03/25, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75029

  7. Oliver Klee updated the commit message in patch set 3 V +1 03/17/25, 16:26

  8. core-ci voted on patch set 3 V +1 03/17/25, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75730

  9. Simon Schaufelberger commented on patch set 3 CR -1 03/17/25, 23:40

    SetupService.php:418

    😄

    SetupServiceTest.php:151

    empty line before please
  10. Lina Wolf uploaded patch set 4 CR -1 V +1 03/18/25, 05:15

  11. Lina Wolf commented on patch set 4 03/18/25, 05:15

    SetupService.php:418 Reply

    Done

    SetupServiceTest.php:151 Reply

    Done
  12. core-ci voted on patch set 4 V +1 03/18/25, 05:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75755

  13. Thomas Hohn commented on patch set 4 03/18/25, 06:41

    SetupService.php:418

    Maybe just return $row['uid'] ?? 0;
  14. Benni Mack commented on patch set 5 V +1 03/24/25, 20:16

    Published edit on patch set 4.
  15. Benni Mack commented on patch set 5 03/24/25, 20:16

    SetupService.php:418 Reply

    Done
  16. core-ci voted on patch set 5 V +1 03/24/25, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76174

  17. Thomas Hohn voted on patch set 5 CR +1 03/25/25, 06:09

  18. Simon Schaufelberger voted on patch set 5 CR +1 V +1 03/25/25, 10:41

  19. Benni Mack commented on patch set 5 03/27/25, 12:05

    SetupService.php:395

    should be (int) casted.
  20. Benni Mack commented on patch set 6 CR +1 V +1 03/27/25, 12:05

    Published edit on patch set 5.
  21. Benni Mack commented on patch set 6 CR +1 03/27/25, 12:05

    SetupService.php:395 Reply

    Done
  22. core-ci voted on patch set 6 V +1 03/27/25, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76448

  23. Georg Ringer voted on patch set 6 CR +1 V +1 03/27/25, 21:01

  24. Benni Mack voted on patch set 6 CR +2 V +2 03/27/25, 21:24

  25. Benni Mack merged patch set 7 03/27/25, 21:24