88431[BUGFIX] Create file mount for setup:begroups:default
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/install/Classes/Service/SetupService.php6+47 −0
- typo3/sysext/install/Configuration/PermissionPreset/be_groups_advanced_editor.yaml+2 −0
- typo3/sysext/install/Configuration/PermissionPreset/be_groups_editor.yaml+2 −0
- typo3/sysext/install/Tests/Functional/Service/Fixtures/CreateUserGroupsCommand.csv+2 −2
- typo3/sysext/install/Tests/Functional/Service/Fixtures/CreateUserGroupsCommandFileMount.csvnew+3 −0
- typo3/sysext/install/Tests/Functional/Service/SetupServiceTest.php2+13 −0
Review log 1925
-
Lina Wolf uploaded patch set 1 03/03/25, 05:25
-
Lina Wolf marked it work in progress 03/03/25, 05:25
-
core-ci voted on patch set 1 V +1 03/03/25, 05:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74988
-
Lina Wolf uploaded patch set 2
V +103/03/25, 16:22 -
Lina Wolf commented on patch set 2 03/03/25, 16:23
This change is ready for review. -
core-ci voted on patch set 2 V +1 03/03/25, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75029
-
Oliver Klee updated the commit message in patch set 3
V +103/17/25, 16:26 -
core-ci voted on patch set 3 V +1 03/17/25, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75730
-
Simon Schaufelberger commented on patch set 3 CR -1 03/17/25, 23:40
SetupService.php:418😄SetupServiceTest.php:151empty line before please -
Lina Wolf uploaded patch set 4
CR -1V +103/18/25, 05:15 -
Lina Wolf commented on patch set 4 03/18/25, 05:15
SetupService.php:418ReplyDoneSetupServiceTest.php:151ReplyDone -
core-ci voted on patch set 4 V +1 03/18/25, 05:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75755
-
Thomas Hohn commented on patch set 4 03/18/25, 06:41
SetupService.php:418Maybe just return $row['uid'] ?? 0; -
Benni Mack commented on patch set 5
V +103/24/25, 20:16Published edit on patch set 4. -
Benni Mack commented on patch set 5 03/24/25, 20:16
SetupService.php:418ReplyDone -
core-ci voted on patch set 5 V +1 03/24/25, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76174
-
Thomas Hohn voted on patch set 5 CR +1 03/25/25, 06:09
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 03/25/25, 10:41
-
Benni Mack commented on patch set 5 03/27/25, 12:05
SetupService.php:395should be (int) casted. -
Benni Mack commented on patch set 6
CR +1V +103/27/25, 12:05Published edit on patch set 5. -
Benni Mack commented on patch set 6 CR +1 03/27/25, 12:05
SetupService.php:395ReplyDone -
core-ci voted on patch set 6 V +1 03/27/25, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76448
-
Georg Ringer voted on patch set 6 CR +1 V +1 03/27/25, 21:01
-
Benni Mack voted on patch set 6 CR +2 V +2 03/27/25, 21:24
-
Benni Mack merged patch set 7 03/27/25, 21:24