Review 13.4 Merged

88438[TASK] Simplify DataHandler->doesRecordExist_pageLookUp()

Christian Kuhn CR +2 V +2 Normal +38 −24 updated 03/03/25, 12:32

Commit message

The amount of repeated queries created by the permission
check related DataHandler methods is stunning. They tend
to do the same thing over and over again with only minor
changes.

This change is a preparation patch to make the database
load of the related methods collapse: We check the page
permission access in PHP instead of within a query. This
allows us to refactor the calling code to hand over the
page row instead of fetching it every time.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 03/03/25, 11:35

  2. core-ci voted on patch set 1 V +1 03/03/25, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75006

  3. Georg Ringer commented on patch set 1 03/03/25, 12:26

    DataHandler.php:7292

    should we move the beuser before everything else?
  4. Christian Kuhn commented on patch set 1 03/03/25, 12:32

    DataHandler.php:7292 Reply

    matter of taste. i tend to have early returns as early as possible and then start gathering further stuff to potentially return again. this way more stuff is 'in place'. hope it is ok to keep it as it.
  5. Christian Kuhn voted on patch set 1 CR +2 V +2 03/03/25, 12:32

  6. Christian Kuhn merged patch set 2 03/03/25, 12:32