88444[BUGFIX] Do not delete records via AJAX anymore
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/Sass/component/_recordlist.scss+0 −4
- Build/Sources/TypeScript/backend/recordlist.ts+0 −121
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php7+16 −5
- typo3/sysext/backend/Resources/Public/Css/backend.css+0 −1
- typo3/sysext/backend/Resources/Public/JavaScript/recordlist.js+1 −1
Review log 1316
-
Andreas Kienast uploaded patch set 1 03/03/25, 15:16
-
Andreas Kienast uploaded patch set 2 03/03/25, 15:19
-
core-ci voted on patch set 1 V +1 03/03/25, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75027
-
core-ci voted on patch set 2 V +1 03/03/25, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75028
-
Andreas Kienast commented on patch set 2 03/03/25, 15:30
The backport to v13 will look differently as this involves AjaxDataHandler directly. -
Benjamin Franzke commented on patch set 2 03/04/25, 07:16
DatabaseRecordList.php:1876I'd use `'redirect' => $this->listURL(). '#t3-table-' . htmlspecialchars($table)` – but it seems other actions like move miss that as well.DatabaseRecordList.php:1880We should use forms + POST, but it seems other writing actions miss that as well. -
Andreas Kienast commented on patch set 2 CR -1 03/04/25, 07:41
DatabaseRecordList.php:1880ReplyGood catch, that's a fuckup anyway... -
Andreas Kienast commented on patch set 2 03/04/25, 07:43
DatabaseRecordList.php:1876ReplyI'd streamline this in a new patch. -
Andreas Kienast uploaded patch set 3
CR -1V +103/04/25, 07:44 -
core-ci voted on patch set 3 V +1 03/04/25, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75071
-
Benjamin Franzke commented on patch set 3 03/04/25, 11:25
DatabaseRecordList.php:1876ReplyAcknowledged -
Christian Kuhn voted on patch set 3 CR +1 V +1 03/05/25, 06:24
-
Benjamin Franzke commented on patch set 3 CR +1 V +1 03/05/25, 08:43
DatabaseRecordList.php:1880Replycan also be fixed later, if you like -
Andreas Kienast commented on patch set 3 03/05/25, 08:50
DatabaseRecordList.php:1880ReplyThat's the usual issue we have at multiple locations. The click is intercepted by the modal component and a GET request is dispatched if the "positive" action is invoked. -
Andreas Kienast voted on patch set 3 CR +2 V +2 03/05/25, 08:56
-
Andreas Kienast merged patch set 4 03/05/25, 10:10