Review main Merged

88444[BUGFIX] Do not delete records via AJAX anymore

Andreas Kienast CR +2 V +2 Normal +17 −132 updated 03/05/25, 10:10

Commit message

Deleting records in the record list is done via AJAX since TYPO3 v7.
Since then, there have been major flaws that cannot get fixed with the
current state of the record list:

* if dependent records shown in the same view get deleted as well, the
  record stays in place
* if a page translation is deleted, all localizations remain in place
  until a reload
* if a page translation is deleted, the localization dropdown to create
  a new translation is not updated

To fix those issues, the record list and its involved sub-components
need a major overhaul. Therefore, deleting records via AJAX is not
possible anymore, the full record list module gets reloaded after
triggering a delete request.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1316

  1. Andreas Kienast uploaded patch set 1 03/03/25, 15:16

  2. Andreas Kienast uploaded patch set 2 03/03/25, 15:19

  3. core-ci voted on patch set 1 V +1 03/03/25, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75027

  4. core-ci voted on patch set 2 V +1 03/03/25, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75028

  5. Andreas Kienast commented on patch set 2 03/03/25, 15:30

    The backport to v13 will look differently as this involves AjaxDataHandler directly.
  6. Benjamin Franzke commented on patch set 2 03/04/25, 07:16

    DatabaseRecordList.php:1876

    I'd use `'redirect' => $this->listURL(). '#t3-table-' . htmlspecialchars($table)` – but it seems other actions like move miss that as well.

    DatabaseRecordList.php:1880

    We should use forms + POST, but it seems other writing actions miss that as well.
  7. Andreas Kienast commented on patch set 2 CR -1 03/04/25, 07:41

    DatabaseRecordList.php:1880 Reply

    Good catch, that's a fuckup anyway...
  8. Andreas Kienast commented on patch set 2 03/04/25, 07:43

    DatabaseRecordList.php:1876 Reply

    I'd streamline this in a new patch.
  9. Andreas Kienast uploaded patch set 3 CR -1 V +1 03/04/25, 07:44

  10. core-ci voted on patch set 3 V +1 03/04/25, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75071

  11. Benjamin Franzke commented on patch set 3 03/04/25, 11:25

    DatabaseRecordList.php:1876 Reply

    Acknowledged
  12. Christian Kuhn voted on patch set 3 CR +1 V +1 03/05/25, 06:24

  13. Benjamin Franzke commented on patch set 3 CR +1 V +1 03/05/25, 08:43

    DatabaseRecordList.php:1880 Reply

    can also be fixed later, if you like
  14. Andreas Kienast commented on patch set 3 03/05/25, 08:50

    DatabaseRecordList.php:1880 Reply

    That's the usual issue we have at multiple locations. The click is intercepted by the modal component and a GET request is dispatched if the "positive" action is invoked.
  15. Andreas Kienast voted on patch set 3 CR +2 V +2 03/05/25, 08:56

  16. Andreas Kienast merged patch set 4 03/05/25, 10:10