88445[TASK] Streamline DataHandler permission checks
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 5
- Build/phpstan/phpstan-baseline.neon+0 −6
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+3 −5
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+421 −551
- typo3/sysext/redirects/Classes/Hooks/DataHandlerSlugUpdateHook.php+3 −4
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+48 −41
Review log 61115
Show 4590 earlier messages
-
Christian Kuhn uploaded patch set 1 03/03/25, 16:57
-
core-ci voted on patch set 1 V -1 03/03/25, 17:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75031
-
Christian Kuhn updated the commit message in patch set 2
V -103/03/25, 17:41 -
core-ci voted on patch set 2 V -1 03/03/25, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75032
-
Christian Kuhn uploaded patch set 3
V -103/05/25, 06:34 -
core-ci voted on patch set 3 V +1 03/05/25, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75136
-
Christian Kuhn uploaded patch set 4
V +103/05/25, 06:45 -
core-ci voted on patch set 4 V +1 03/05/25, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75137
-
Christian Kuhn uploaded patch set 5
V +103/05/25, 06:55 -
core-ci voted on patch set 5 V +1 03/05/25, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75138
-
Christian Kuhn uploaded patch set 6
V +103/05/25, 11:32 -
core-ci voted on patch set 6 V +1 03/05/25, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75158
-
Christian Kuhn rebased onto patch set 7
V +103/05/25, 14:33 -
core-ci voted on patch set 7 V +1 03/05/25, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75184
-
Christian Kuhn uploaded patch set 8 03/07/25, 08:27
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 8 V +1 03/07/25, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75276
-
Christian Kuhn uploaded patch set 9
V +103/07/25, 14:44 -
core-ci voted on patch set 9 V +1 03/07/25, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75307
-
Christian Kuhn uploaded patch set 10
V +103/07/25, 15:08 -
core-ci voted on patch set 10 V +1 03/07/25, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75310
-
Christian Kuhn uploaded patch set 11
V +103/07/25, 15:19 -
core-ci voted on patch set 11 V +1 03/07/25, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75311
-
Christian Kuhn uploaded patch set 12
V +103/07/25, 15:35 -
core-ci voted on patch set 12 V +1 03/07/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75312
-
Christian Kuhn uploaded patch set 13
V +103/07/25, 15:46 -
Christian Kuhn uploaded patch set 14 03/07/25, 15:48
-
Christian Kuhn uploaded patch set 15 03/07/25, 15:55
-
core-ci voted on patch set 13 V -1 03/07/25, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75313
-
core-ci voted on patch set 14 V -1 03/07/25, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75314
-
core-ci voted on patch set 15 V -1 03/07/25, 16:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75315
-
Christian Kuhn uploaded patch set 16
V -103/13/25, 15:16 -
core-ci voted on patch set 16 V +1 03/13/25, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75554
-
Christian Kuhn uploaded patch set 17
V +103/13/25, 15:50 -
core-ci voted on patch set 17 V +1 03/13/25, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75556
-
Christian Kuhn uploaded patch set 18
V +103/13/25, 15:57 -
core-ci voted on patch set 18 V +1 03/13/25, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75558
-
Christian Kuhn uploaded patch set 19
V +103/13/25, 16:16 -
core-ci voted on patch set 19 V +1 03/13/25, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75559
-
Christian Kuhn uploaded patch set 20
V +103/13/25, 16:31 -
core-ci voted on patch set 20 V +1 03/13/25, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75560
-
Christian Kuhn uploaded patch set 21
V +103/14/25, 12:04 -
core-ci voted on patch set 21 V -1 03/14/25, 12:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75588
-
Christian Kuhn uploaded patch set 22
V -103/14/25, 12:14 -
core-ci voted on patch set 22 V +1 03/14/25, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75589
-
Christian Kuhn uploaded patch set 23
V +103/14/25, 12:24 -
core-ci voted on patch set 23 V +1 03/14/25, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75591
-
Christian Kuhn uploaded patch set 24
V +103/14/25, 12:56 -
core-ci voted on patch set 24 V +1 03/14/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75593
-
Christian Kuhn uploaded patch set 25
V +103/14/25, 13:24 -
core-ci voted on patch set 25 V +1 03/14/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75594
-
Christian Kuhn uploaded patch set 26
V +103/14/25, 14:14 -
core-ci voted on patch set 26 V +1 03/14/25, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75595
-
Christian Kuhn uploaded patch set 27
V +103/14/25, 14:28 -
core-ci voted on patch set 27 V +1 03/14/25, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75596
-
Christian Kuhn uploaded patch set 28
V +103/14/25, 14:44 -
core-ci voted on patch set 28 V +1 03/14/25, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75599
-
Christian Kuhn uploaded patch set 29
V +103/14/25, 15:06 -
core-ci voted on patch set 29 V +1 03/14/25, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75600
-
Christian Kuhn uploaded patch set 30
V +103/14/25, 15:26 -
core-ci voted on patch set 30 V +1 03/14/25, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75603
-
Christian Kuhn uploaded patch set 31
V +103/14/25, 15:51 -
core-ci voted on patch set 31 V +1 03/14/25, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75604
-
Christian Kuhn uploaded patch set 32
V +103/14/25, 16:08 -
core-ci voted on patch set 32 V +1 03/14/25, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75607
-
Christian Kuhn uploaded patch set 33
V +103/14/25, 16:38 -
core-ci voted on patch set 33 V +1 03/14/25, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75608
-
Christian Kuhn uploaded patch set 34
V +103/14/25, 16:57 -
core-ci voted on patch set 34 V +1 03/14/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75609
-
Christian Kuhn uploaded patch set 35
V +103/14/25, 17:22 -
core-ci voted on patch set 35 V +1 03/14/25, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75610
-
Christian Kuhn uploaded patch set 36
V +103/14/25, 20:19 -
Christian Kuhn uploaded patch set 37 03/14/25, 20:20
-
core-ci voted on patch set 36 V +1 03/14/25, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75611
-
core-ci voted on patch set 37 V +1 03/14/25, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75612
-
Christian Kuhn uploaded patch set 38
V +103/14/25, 20:44 -
core-ci voted on patch set 38 V +1 03/14/25, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75613
-
Christian Kuhn uploaded patch set 39
V +103/14/25, 21:16 -
core-ci voted on patch set 39 V +1 03/14/25, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75614
-
Christian Kuhn uploaded patch set 40
V +103/14/25, 21:49 -
core-ci voted on patch set 40 V +1 03/14/25, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75616
-
Christian Kuhn uploaded patch set 41
V +103/14/25, 22:03 -
core-ci voted on patch set 41 V +1 03/14/25, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75617
-
Christian Kuhn uploaded patch set 42
V +103/14/25, 22:13 -
core-ci voted on patch set 42 V -1 03/14/25, 22:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75618
-
Christian Kuhn uploaded patch set 43
V -103/14/25, 22:55 -
core-ci voted on patch set 43 V -1 03/14/25, 23:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75619
-
Christian Kuhn uploaded patch set 44
V -103/14/25, 23:11 -
core-ci voted on patch set 44 V +1 03/14/25, 23:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75620
-
Christian Kuhn uploaded patch set 45
V +103/14/25, 23:33 -
core-ci voted on patch set 45 V -1 03/14/25, 23:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75621
-
Christian Kuhn uploaded patch set 46
V -103/15/25, 00:05 -
core-ci voted on patch set 46 V -1 03/15/25, 00:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75623
-
Christian Kuhn uploaded patch set 47
V -103/15/25, 00:25 -
core-ci voted on patch set 47 V -1 03/15/25, 00:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75624
-
Christian Kuhn uploaded patch set 48
V -103/15/25, 00:40 -
core-ci voted on patch set 48 V +1 03/15/25, 00:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75625
-
Christian Kuhn uploaded patch set 49
V +103/17/25, 10:20 -
core-ci voted on patch set 49 V -1 03/17/25, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75705
-
Christian Kuhn uploaded patch set 50
V -103/17/25, 12:16 -
core-ci voted on patch set 50 V +1 03/17/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75710
-
Christian Kuhn uploaded patch set 51
V +103/17/25, 12:40 -
Christian Kuhn uploaded patch set 52 03/17/25, 12:42
-
core-ci voted on patch set 51 V +1 03/17/25, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75711
-
core-ci voted on patch set 52 V +1 03/17/25, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75712
-
Christian Kuhn uploaded patch set 53
V +103/18/25, 11:41 -
core-ci voted on patch set 53 V +1 03/18/25, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75775
-
Christian Kuhn updated the commit message in patch set 54
V +103/18/25, 12:04 -
core-ci voted on patch set 54 V +1 03/18/25, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75776
-
Stefan Bürk voted on patch set 54 CR +1 03/18/25, 20:56
-
Stefan Bürk voted on patch set 54 V +1 03/19/25, 02:31
-
Benni Mack voted on patch set 54 CR +1 V +1 03/19/25, 08:04
-
Christian Kuhn voted on patch set 54 CR +2 V +2 03/19/25, 08:28
-
Christian Kuhn merged patch set 55 03/19/25, 08:28
-
Oliver Hader commented on patch set 55 02/04/26, 11:15
DataHandler.php:7506Handling the root-level-restrictions (e.g. like in `sys_redirect` with `security/ignoreRootLevelRestriction`) seems still to be missing... -
Oliver Hader commented on patch set 55 02/04/26, 16:19
DataHandler.php:7506Reply