Review main Merged

88447[TASK] Use TcaSchema in NewRecordController

Georg Ringer CR +2 V +2 Normal +53 −73 updated 03/10/25, 09:59

Commit message

Use Schema API in the NewRecordController to avoid
$GLOBALS[TCA].

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1014

  1. Georg Ringer uploaded patch set 1 03/03/25, 19:03

  2. Georg Ringer commented on patch set 1 03/03/25, 19:03

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 03/03/25, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75042

  4. Benni Mack uploaded patch set 2 V -1 03/04/25, 08:36

  5. core-ci voted on patch set 2 V +1 03/04/25, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75081

  6. Benni Mack updated the commit message in patch set 3 V +1 03/04/25, 10:19

  7. core-ci voted on patch set 3 V +1 03/04/25, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75086

  8. Benni Mack voted on patch set 3 CR +1 V +1 03/06/25, 17:41

  9. Oli Bartsch uploaded patch set 4 CR +1 V +1 03/07/25, 09:05

  10. Oli Bartsch commented on patch set 4 CR +1 V +1 03/07/25, 09:05

    13.4?

    NewRecordController.php:91

    Those need a default value then, because they are not set in the constructor.
  11. core-ci voted on patch set 4 V +1 03/07/25, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75282

  12. Benni Mack voted on patch set 4 CR +1 V +1 03/10/25, 09:44

  13. Benni Mack voted on patch set 4 CR +2 V +2 03/10/25, 09:59

  14. Benni Mack merged patch set 5 03/10/25, 09:59