88482[BUGFIX] Provide _LOCALIZED_UID in RawRecord
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2229
Show 34 earlier messages
-
Georg Ringer uploaded patch set 1 03/04/25, 16:20
-
Georg Ringer commented on patch set 1 03/04/25, 16:20
This change is ready for review. -
core-ci voted on patch set 1 V -1 03/04/25, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75108
-
Benni Mack commented on patch set 1 03/04/25, 16:31
RawRecord.php:75I suggest to put the computed Properties into a subarray "computedProperties.localizedUid"
-
Benni Mack commented on patch set 2
V -103/18/25, 10:10Published edit on patch set 1. -
core-ci voted on patch set 2 V -1 03/18/25, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75770
-
Benni Mack uploaded patch set 3
V -103/21/25, 19:24 -
Benni Mack uploaded patch set 4 03/21/25, 19:24
-
Benni Mack commented on patch set 4 03/21/25, 19:29
RawRecord.php:75ReplyDone -
core-ci voted on patch set 3 V -1 03/21/25, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75973
-
core-ci voted on patch set 4 V +1 03/21/25, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75974
-
Benni Mack voted on patch set 4 CR +1 V +1 03/21/25, 19:46
-
Benni Mack uploaded patch set 5
CR +1V +103/21/25, 19:50 -
Benni Mack voted on patch set 5 CR +1 V +1 03/21/25, 19:50
-
core-ci voted on patch set 5 V +1 03/21/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75976
-
Benni Mack uploaded patch set 6
CR +1V +103/22/25, 09:28 -
core-ci voted on patch set 6 V +1 03/22/25, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76011
-
Benni Mack voted on patch set 6 CR +1 V +1 03/22/25, 09:46
-
Jörg Bösche voted on patch set 6 CR +1 03/24/25, 08:58
-
Garvin Hicking commented on patch set 6 03/24/25, 18:51
RawRecord.php:82Sorry if I'm not understanding this - but: Shouldn't a "toArray()" method return a "pure" array? In this case it holds an object in a subkey. So maybe computedProperties should also receive an `toArray()` method, and that in turn could do the NULL checks here for collating filled properties and serializing the getter calls to actual values? Then a `if ((array)$this->computedProperties !== [])` check could be done here to only attach it if it has properties? On the other hand: I'd probably always add `_computed` even with an empty array then (respectively, an array with all array keys set to null), even if all its properties are NULL...? -
Benni Mack uploaded patch set 7
CR +1V +103/26/25, 13:56 -
Benni Mack commented on patch set 7 03/26/25, 13:57
RawRecord.php:82ReplyI hope the solution works for you. I feel this is the most natural solution now. -
core-ci voted on patch set 7 V +1 03/26/25, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76385
-
Garvin Hicking commented on patch set 7 CR +1 V +1 03/26/25, 15:27
RawRecord.php:82Replynice one, lgtm, thanks for doing another loop on this, I feel this is worth it. Since the interface and implementation os stated as "subject to change" its IMO fair to do this for v13 patchlevel. -
Benni Mack commented on patch set 7 CR +2 V +2 03/26/25, 15:28
Record API is next up after Schema API is in place, so it's good to have such changes backported to v13 as well. -
Benni Mack merged patch set 8 03/26/25, 15:28
-
Nikita Hovratov commented on patch set 8 03/26/25, 16:12
RawRecord.php:82ReplyWasn't it possible to do without breaking change for v13? Now I need to do awkward version constraints in Content Blocks. Not sure if it is already used elsewhere. -
Benni Mack commented on patch set 8 03/26/25, 16:18
RawRecord.php:82Replywhat is breaking now? -
Benni Mack commented on patch set 8 03/26/25, 16:19
RawRecord.php:82ReplyAaah, the change in the interface? Correct we shouldn't do that (I thought it was internal, like the rest of the Record API)