Review main Merged

88482[BUGFIX] Provide _LOCALIZED_UID in RawRecord

Georg Ringer CR +2 V +2 Easy +43 −7 updated 03/26/25, 16:19

Commit message

To be able to use translations, the _LOCALIZED_UID must be provided as
well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2229

Show 34 earlier messages
  1. Georg Ringer uploaded patch set 1 03/04/25, 16:20

  2. Georg Ringer commented on patch set 1 03/04/25, 16:20

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 03/04/25, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75108

  4. Benni Mack commented on patch set 1 03/04/25, 16:31

    RawRecord.php:75

    I suggest to put the computed Properties into a subarray "computedProperties.localizedUid"
  1. Benni Mack commented on patch set 2 V -1 03/18/25, 10:10

    Published edit on patch set 1.
  2. core-ci voted on patch set 2 V -1 03/18/25, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75770

  3. Benni Mack uploaded patch set 3 V -1 03/21/25, 19:24

  4. Benni Mack uploaded patch set 4 03/21/25, 19:24

  5. Benni Mack commented on patch set 4 03/21/25, 19:29

    RawRecord.php:75 Reply

    Done
  6. core-ci voted on patch set 3 V -1 03/21/25, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75973

  7. core-ci voted on patch set 4 V +1 03/21/25, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75974

  8. Benni Mack voted on patch set 4 CR +1 V +1 03/21/25, 19:46

  9. Benni Mack uploaded patch set 5 CR +1 V +1 03/21/25, 19:50

  10. Benni Mack voted on patch set 5 CR +1 V +1 03/21/25, 19:50

  11. core-ci voted on patch set 5 V +1 03/21/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75976

  12. Benni Mack uploaded patch set 6 CR +1 V +1 03/22/25, 09:28

  13. core-ci voted on patch set 6 V +1 03/22/25, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76011

  14. Benni Mack voted on patch set 6 CR +1 V +1 03/22/25, 09:46

  15. Jörg Bösche voted on patch set 6 CR +1 03/24/25, 08:58

  16. Garvin Hicking commented on patch set 6 03/24/25, 18:51

    RawRecord.php:82

    Sorry if I'm not understanding this - but: Shouldn't a "toArray()" method return a "pure" array? In this case it holds an object in a subkey. So maybe computedProperties should also receive an `toArray()` method, and that in turn could do the NULL checks here for collating filled properties and serializing the getter calls to actual values? Then a `if ((array)$this->computedProperties !== [])` check could be done here to only attach it if it has properties? On the other hand: I'd probably always add `_computed` even with an empty array then (respectively, an array with all array keys set to null), even if all its properties are NULL...?
  17. Benni Mack uploaded patch set 7 CR +1 V +1 03/26/25, 13:56

  18. Benni Mack commented on patch set 7 03/26/25, 13:57

    RawRecord.php:82 Reply

    I hope the solution works for you. I feel this is the most natural solution now.
  19. core-ci voted on patch set 7 V +1 03/26/25, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76385

  20. Garvin Hicking commented on patch set 7 CR +1 V +1 03/26/25, 15:27

    RawRecord.php:82 Reply

    nice one, lgtm, thanks for doing another loop on this, I feel this is worth it. Since the interface and implementation os stated as "subject to change" its IMO fair to do this for v13 patchlevel.
  21. Benni Mack commented on patch set 7 CR +2 V +2 03/26/25, 15:28

    Record API is next up after Schema API is in place, so it's good to have such changes backported to v13 as well.
  22. Benni Mack merged patch set 8 03/26/25, 15:28

  23. Nikita Hovratov commented on patch set 8 03/26/25, 16:12

    RawRecord.php:82 Reply

    Wasn't it possible to do without breaking change for v13? Now I need to do awkward version constraints in Content Blocks. Not sure if it is already used elsewhere.
  24. Benni Mack commented on patch set 8 03/26/25, 16:18

    RawRecord.php:82 Reply

    what is breaking now?
  25. Benni Mack commented on patch set 8 03/26/25, 16:19

    RawRecord.php:82 Reply

    Aaah, the change in the interface? Correct we shouldn't do that (I thought it was internal, like the rest of the Record API)