Review main Merged

88484[TASK] Update TypeScript to v5.8

Benjamin Franzke CR +2 V +2 Normal +82 −89 updated 03/05/25, 09:07

Commit message

Update to the latest release which features granular checks for branches
in return expressions (good for us, as we're not yet free of `any`) and
CommonJS module interop improvements (not that important for us, as
we're already using ECMAScript Modules), also see:
https://typescriptlang.org/docs/handbook/release-notes/typescript-5-8

npm install --save-dev \
    typescript@^5.8 \
    @typescript-eslint/eslint-plugin@^8.26 \
    @typescript-eslint/parser@^8.26 \
    @typescript-eslint/typescript-estree@^8.26

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Benjamin Franzke uploaded patch set 1 03/05/25, 03:16

  2. core-ci voted on patch set 1 V +1 03/05/25, 03:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75117

  3. Andreas Kienast commented on patch set 1 03/05/25, 06:37

    Is there a reason you omitted the version ranges (`^`)?
  4. Benjamin Franzke commented on patch set 1 CR -1 03/05/25, 07:38

    Reply

    no, sorry, I was convinced that npm would set these automatically, will recheck
  5. Benjamin Franzke uploaded patch set 2 CR -1 V +1 03/05/25, 07:40

  6. Benjamin Franzke commented on patch set 2 03/05/25, 07:40

    Reply

    Done
  7. Andreas Kienast voted on patch set 2 CR +1 V +1 03/05/25, 07:46

  8. core-ci voted on patch set 2 V +1 03/05/25, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75142

  9. Benjamin Kott voted on patch set 2 CR +1 V +1 03/05/25, 08:54

  10. Benjamin Franzke voted on patch set 2 CR +2 V +2 03/05/25, 08:54

  11. Benjamin Franzke merged patch set 3 03/05/25, 09:07