88485[TASK] Annotate correct return type in PageRepository
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 1
Files 3
Review log 67
-
Benjamin Franzke commented on patch set 1 03/05/25, 03:20
Cherry Picked from branch main. -
Benjamin Franzke updated the commit message in patch set 2 03/05/25, 03:25
-
Benjamin Franzke commented on patch set 2 CR +1 V +1 03/05/25, 03:25
12.4 seems not to be affected, `getDefaultConstraints()` doesn't exist there and `PageRepository::enableFields` has a `string` return type annotation. -
Benjamin Franzke marked it work in progress 03/05/25, 03:26
-
core-ci voted on patch set 2 V +1 03/05/25, 03:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75121
-
Benjamin Franzke commented on patch set 2 CR +2 V +2 03/05/25, 06:10
This change is ready for review. -
Benjamin Franzke merged patch set 3 03/05/25, 06:10