Review 13.4 Merged

88485[TASK] Annotate correct return type in PageRepository

Benjamin Franzke CR +2 V +2 Easy +6 −3 updated 03/05/25, 06:10

Commit message

The method getDefaultConstraints() returns a list of
strings or CompositeExpression.
The return annotation must accurately reflect this.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Benjamin Franzke commented on patch set 1 03/05/25, 03:20

    Cherry Picked from branch main.
  2. Benjamin Franzke updated the commit message in patch set 2 03/05/25, 03:25

  3. Benjamin Franzke commented on patch set 2 CR +1 V +1 03/05/25, 03:25

    12.4 seems not to be affected, `getDefaultConstraints()` doesn't exist there and `PageRepository::enableFields` has a `string` return type annotation.
  4. Benjamin Franzke marked it work in progress 03/05/25, 03:26

  5. core-ci voted on patch set 2 V +1 03/05/25, 03:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75121

  6. Benjamin Franzke commented on patch set 2 CR +2 V +2 03/05/25, 06:10

    This change is ready for review.
  7. Benjamin Franzke merged patch set 3 03/05/25, 06:10