88511[BUGFIX] Avoid layout shifts when dragging content blocks in Page module
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 17
- Build/Sources/Sass/component/_tree.scss+15 −2
- Build/Sources/Sass/module/_page.scss+8 −13
- Build/Sources/TypeScript/backend/layout-module/drag-drop.ts+12 −31
- Build/Sources/TypeScript/backend/tree/page-tree.ts+9 −1
- Build/Sources/TypeScript/backend/utility/drag-drop-utility.tsnew+47 −0
- Build/Sources/TypeScript/backend/wizard/move-content-element.ts2+13 −4
- typo3/sysext/backend/Classes/Tree/View/ContentMovingPagePositionMap.php+1 −0
- typo3/sysext/backend/Resources/Private/Language/Wizards/move_content_elements.xlf+5 −2
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/ColumnHeader.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/RecordDefault/Header.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ContentElement/MoveElement.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+11 −9
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/drag-drop.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-tree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/utility/drag-drop-utility.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/move-content-element.js+1 −1
Review log 3545
Show 1420 earlier messages
-
Benjamin Kott uploaded patch set 1 03/06/25, 13:21
-
core-ci voted on patch set 1 V +1 03/06/25, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75223
-
Benjamin Kott uploaded patch set 2
V +103/06/25, 14:28 -
core-ci voted on patch set 2 V +1 03/06/25, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75224
-
Georg Ringer voted on patch set 2 CR +1 V +1 03/06/25, 20:15
-
Andreas Kienast commented on patch set 2 V -1 03/07/25, 07:21
Funny bug in Safari – I get trapped in copy mode by doing the following: 1. Press Option key to start a copy action 2. Drag a content element 3. Decide to abort the action 4. Do not press Option key anymore 5. Drop element somewhere but in a drop area After this I'm trapped, the next drag automatically starts in copy mode. If I swap (4) and (5), this does not occur. -
Benjamin Kott uploaded patch set 3
CR +1V +103/07/25, 11:22 -
core-ci voted on patch set 3 V +1 03/07/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75293
-
Benjamin Kott uploaded patch set 4
V +103/07/25, 11:34 -
core-ci voted on patch set 4 V +1 03/07/25, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75294
-
Benjamin Kott uploaded patch set 5
V +103/07/25, 12:46 -
Benjamin Kott commented on patch set 5 03/07/25, 12:51
Reply
resolved -
core-ci voted on patch set 5 V +1 03/07/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75299
-
Benjamin Franzke voted on patch set 5 CR +1 V +1 03/07/25, 12:56
-
Andreas Kienast voted on patch set 5 CR +1 V +1 03/07/25, 13:55
-
Oli Bartsch voted on patch set 5 CR +1 V +1 03/07/25, 15:36
-
Oli Bartsch commented on patch set 5 CR 0 V -1 03/07/25, 18:34
Copy actually does still not work for me. Only moving is possible. I think we are currently miss to set "makeCopy" as queryParam on the move element ajax call in page-tree.ts Therefore, the move modal is not "executed" in copy mode, leading to always moving the element. -
Oli Bartsch uploaded patch set 6
CR +1V +103/07/25, 20:49 -
Oli Bartsch commented on patch set 6 CR +1 V +1 03/07/25, 20:52
Reply
The requested action is now fetched in page-tree and forwarded to the move element controller. Additionally, I updated the move element component to properly display the requested action also in the headline. I'm not quite sure about the public isCopyModifierFromEvent() method in drag-drop but don't wanted to duplicate the code. However, please adjust as youn like. -
core-ci voted on patch set 6 V +1 03/07/25, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75326
-
Benjamin Kott commented on patch set 6 CR -1 03/10/25, 07:29
we now have a dependency between the pagetree and the page layout js this needs to be broken up -
Benjamin Kott commented on patch set 6 03/10/25, 07:34
Reply
also the copy modifier is not catched on windows and linux when hovering the pagetree -
Oli Bartsch commented on patch set 6 03/10/25, 08:09
Reply
The dependency to drag-drop actually has been there before by importing "ContentElementDragDropData" -
Benjamin Franzke commented on patch set 6 03/10/25, 08:25
Reply
No, `ContentElementDragDropData` is a type import, that's a build-time dependency, not a runtime dependency. This became more clear with the following patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88248/10/Build/Sources/TypeScript/backend/tree/page-tree.ts -
Benjamin Kott uploaded patch set 7
CR +1V +103/10/25, 08:53 -
Benjamin Kott commented on patch set 7 03/10/25, 08:56
Reply
Done -
core-ci voted on patch set 7 V +1 03/10/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75395
-
Benjamin Franzke voted on patch set 7 CR +1 V +1 03/10/25, 09:01
-
Andreas Kienast voted on patch set 7 CR +1 V +1 03/10/25, 10:25
-
Benjamin Kott voted on patch set 7 CR +2 V +2 03/10/25, 10:38
-
Benjamin Franzke voted on patch set 7 CR 0 V -1 03/10/25, 10:55
-
Benjamin Kott uploaded patch set 8
CR +1V +103/10/25, 11:15 -
core-ci voted on patch set 8 V +1 03/10/25, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75406
-
Benjamin Kott uploaded patch set 9
V +103/10/25, 11:23 -
core-ci voted on patch set 9 V +1 03/10/25, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75407
-
Benjamin Franzke voted on patch set 9 CR +1 V +1 03/10/25, 11:45
-
Andreas Kienast commented on patch set 9 03/10/25, 11:56
move-page.ts:54message If this is fixed, this patch obsoletes https://review.typo3.org/c/Packages/TYPO3.CMS/+/88535. -
Andreas Kienast commented on patch set 9 03/10/25, 11:58
move-content-element.ts:87message -
Benjamin Kott uploaded patch set 10
CR +1V +103/10/25, 12:12 -
Benjamin Kott commented on patch set 10 03/10/25, 12:12
move-content-element.ts:87ReplyDonemove-page.ts:54ReplyDone -
Benjamin Franzke voted on patch set 10 CR +1 V +1 03/10/25, 12:14
-
Andreas Kienast voted on patch set 10 CR +1 V +1 03/10/25, 12:15
-
Benjamin Kott voted on patch set 10 CR +2 V +2 03/10/25, 12:18
-
core-ci voted on patch set 10 V +1 03/10/25, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75413
-
Benjamin Kott merged patch set 11 03/10/25, 12:25