Review main Merged

88513[BUGFIX] Use the correct DI services scope in PackageActivationService

Helmut Hummel CR +2 V +2 Easy +19 −11 updated 03/10/25, 14:42

Commit message

When activating an extension in TYPO3 classic mode,
a new DI container is built and made active for the PHP process
that runs the activation. Therefore it is required, that all services
that depend on the new container and TCA are fetched from the new container
and not already being injected into the service.

Also make sure, that when the container is reset, that
the TCA globals is also reset, so that the global array
matches the state in the initial service that is from then
on used by code executed after that point.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Helmut Hummel uploaded patch set 1 03/06/25, 15:48

  2. core-ci voted on patch set 1 V +1 03/06/25, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75229

  3. Benni Mack voted on patch set 1 CR +1 V +1 03/07/25, 12:13

  4. Christian Kuhn voted on patch set 1 CR +1 03/07/25, 14:16

  5. Georg Ringer voted on patch set 1 CR +2 V +2 03/08/25, 20:07

  6. Georg Ringer merged patch set 2 03/08/25, 20:07

  7. Helmut Hummel commented on patch set 2 03/10/25, 14:42

    Thanks Georg!
  8. Helmut Hummel commented on patch set 2 03/10/25, 14:42

    Thanks Georg!