Review main Merged

88514[TASK] Use Schema API in NewContentElementController

Georg Ringer CR +2 V +2 Hard +375 −369 updated 03/10/25, 10:22

Commit message

This change uses Schema API in NewContentElement
Controller, but also streamlines some tests
and their filenames.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1216

  1. Georg Ringer uploaded patch set 1 03/06/25, 16:45

  2. Georg Ringer commented on patch set 1 03/06/25, 16:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 03/06/25, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75231

  4. Georg Ringer uploaded patch set 2 V -1 03/06/25, 17:10

  5. core-ci voted on patch set 2 V -1 03/06/25, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75232

  6. Benni Mack uploaded patch set 3 V -1 03/06/25, 20:41

  7. core-ci voted on patch set 3 V -1 03/06/25, 20:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75243

  8. Benni Mack uploaded patch set 4 V -1 03/06/25, 20:54

  9. core-ci voted on patch set 4 V +1 03/06/25, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75245

  10. Benni Mack voted on patch set 4 CR +1 V +1 03/07/25, 10:57

  11. Simon Schaufelberger voted on patch set 4 CR +1 V +1 03/10/25, 10:02

  12. Simon Schaufelberger commented on patch set 4 03/10/25, 10:03

    NewContentElementController.php:66

    why is this not readonly?
  13. Benni Mack commented on patch set 4 03/10/25, 10:06

    NewContentElementController.php:66 Reply

    because of existing tests of this class which are unrelated, which I did not want to modify as this turned out to fail. Replacing these tests here are necessary to tackle rather sooner than later (but then: v14 only).
  14. Simon Schaufelberger commented on patch set 4 03/10/25, 10:20

    NewContentElementController.php:66 Reply

    Ok, I was just wondering about the inconsistency because on other places the TcaSchemaFactory is readonly.
  15. Benni Mack commented on patch set 4 CR +2 V +2 03/10/25, 10:22

    NewContentElementController.php:66 Reply

    good that you checked though
  16. Benni Mack merged patch set 5 03/10/25, 10:22