88514[TASK] Use Schema API in NewContentElementController
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php4+18 −14
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/NewContentElementControllerTest.phpnew+356 −0
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/NewContentElementWizardControllerTest.phpdeleted+0 −145
- typo3/sysext/backend/Tests/Unit/Controller/ContentElement/NewContentElementControllerTest.php+0 −209
- typo3/sysext/core/Classes/Schema/TcaSchemaFactory.php+1 −1
Review log 1216
-
Georg Ringer uploaded patch set 1 03/06/25, 16:45
-
Georg Ringer commented on patch set 1 03/06/25, 16:45
This change is ready for review. -
core-ci voted on patch set 1 V -1 03/06/25, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75231
-
Georg Ringer uploaded patch set 2
V -103/06/25, 17:10 -
core-ci voted on patch set 2 V -1 03/06/25, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75232
-
Benni Mack uploaded patch set 3
V -103/06/25, 20:41 -
core-ci voted on patch set 3 V -1 03/06/25, 20:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75243
-
Benni Mack uploaded patch set 4
V -103/06/25, 20:54 -
core-ci voted on patch set 4 V +1 03/06/25, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75245
-
Benni Mack voted on patch set 4 CR +1 V +1 03/07/25, 10:57
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 03/10/25, 10:02
-
Simon Schaufelberger commented on patch set 4 03/10/25, 10:03
NewContentElementController.php:66why is this not readonly? -
Benni Mack commented on patch set 4 03/10/25, 10:06
NewContentElementController.php:66Replybecause of existing tests of this class which are unrelated, which I did not want to modify as this turned out to fail. Replacing these tests here are necessary to tackle rather sooner than later (but then: v14 only). -
Simon Schaufelberger commented on patch set 4 03/10/25, 10:20
NewContentElementController.php:66ReplyOk, I was just wondering about the inconsistency because on other places the TcaSchemaFactory is readonly. -
Benni Mack commented on patch set 4 CR +2 V +2 03/10/25, 10:22
NewContentElementController.php:66Replygood that you checked though -
Benni Mack merged patch set 5 03/10/25, 10:22