Review main Merged

88516[TASK] Make use of Schema API in EXT:impexp

Georg Ringer CR +2 V +2 Hard +177 −104 updated 04/08/25, 16:18

Commit message

This change removes any usage from $GLOBALS[TCA]
from EXT:impexp.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1115

  1. Georg Ringer uploaded patch set 1 03/06/25, 18:46

  2. Benni Mack commented on patch set 1 03/06/25, 18:53

    ExportController.php:364

    you can call ->getNames() on the collection
  3. core-ci voted on patch set 1 V -1 03/06/25, 18:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75237

  4. Benni Mack uploaded patch set 2 V -1 03/31/25, 20:46

  5. Benni Mack commented on patch set 2 03/31/25, 20:51

    ExportController.php:364 Reply

    Done
  6. core-ci voted on patch set 2 V -1 03/31/25, 21:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76734

  7. Benni Mack uploaded patch set 3 V -1 04/04/25, 10:27

  8. core-ci voted on patch set 3 V -1 04/04/25, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76998

  9. Benni Mack uploaded patch set 4 V -1 04/08/25, 15:20

  10. Benni Mack marked it ready for review 04/08/25, 15:20

  11. core-ci voted on patch set 4 V +1 04/08/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77213

  12. Benni Mack voted on patch set 4 CR +1 V +1 04/08/25, 15:29

  13. Christian Kuhn voted on patch set 4 CR +1 V +1 04/08/25, 15:45

  14. Benni Mack voted on patch set 4 CR +2 V +2 04/08/25, 16:18

  15. Benni Mack merged patch set 5 04/08/25, 16:18