88519[!!!][TASK] Use Record API in Page Module Preview Rendering
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Jochen Roth +1
- Matthias Vogel +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/Preview/FluidBasedContentPreviewRenderer.php+15 −27
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php4+31 −28
- typo3/sysext/backend/Classes/Preview/StandardPreviewRendererResolver.php+6 −5
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumn.php+4 −3
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php5+39 −50
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php6+7 −6
- typo3/sysext/backend/Classes/View/Event/AbstractSectionMarkupGeneratedEvent.php+5 −0
- typo3/sysext/backend/Classes/View/Event/PageContentPreviewRenderingEvent.php2+4 −3
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html2+1 −1
- typo3/sysext/backend/Tests/Unit/Preview/StandardPreviewRendererResolverTest.php+15 −12
- typo3/sysext/core/Classes/Domain/FlexFormFieldValues.php+9 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-92434-UseRecordAPIInPageModulePreviewRendering.rstnew+180 −0
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php2+15 −12
- typo3/sysext/form/Classes/ViewHelpers/Be/RenderContentElementPreviewViewHelper.php2+2 −0
Review log 2841
Show 916 earlier messages
-
Benni Mack uploaded patch set 1 03/06/25, 23:44
-
core-ci voted on patch set 1 V -1 03/06/25, 23:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75255
-
Benni Mack marked it work in progress 03/22/25, 12:35
-
Oli Bartsch uploaded patch set 2
V -104/15/25, 14:09 -
core-ci voted on patch set 2 V -1 04/15/25, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77765
-
Oli Bartsch uploaded patch set 3
V -104/16/25, 08:31 -
core-ci voted on patch set 3 V +1 04/16/25, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77812
-
Oli Bartsch uploaded patch set 4
V +104/16/25, 09:48 -
core-ci voted on patch set 4 V +1 04/16/25, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77823
-
Benni Mack uploaded patch set 5
V +107/24/25, 09:00 -
core-ci voted on patch set 5 V -1 07/24/25, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82226
-
Benni Mack uploaded patch set 6
V -110/13/25, 07:52 -
core-ci voted on patch set 6 V -1 10/13/25, 08:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86521
-
Matthias Vogel uploaded patch set 7
V -110/27/25, 11:03 -
core-ci voted on patch set 7 V -1 10/27/25, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87636
-
Matthias Vogel uploaded patch set 8
V -110/27/25, 11:13
-
core-ci voted on patch set 8 V -1 10/27/25, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87638
-
Matthias Vogel uploaded patch set 9
V -110/27/25, 11:54 -
core-ci voted on patch set 9 V -1 10/27/25, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87643
-
Matthias Vogel uploaded patch set 10
V -110/27/25, 12:29 -
core-ci voted on patch set 10 V +1 10/27/25, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87647
-
Benni Mack commented on patch set 10 10/27/25, 16:17
StandardContentPreviewRenderer.php:372I think this might be used by others (just thinking out loud)PageContentPreviewRenderingEvent.php:48that's breaking IMHORecord.html:9the info that the item.record is now a record object, is important to know for externals -
Benni Mack uploaded patch set 11
V +110/27/25, 16:43 -
Benni Mack marked it ready for review 10/27/25, 16:53
-
Benni Mack commented on patch set 11 10/27/25, 16:53
StandardContentPreviewRenderer.php:126ReplyDoneStandardContentPreviewRenderer.php:372ReplyDonePageContentPreviewRenderingEvent.php:48ReplyDoneRecord.html:9ReplyDone -
core-ci voted on patch set 11 V +1 10/27/25, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87686
-
Sven Liebert commented on patch set 11 10/27/25, 20:21
GridColumnItem.php:234Maybe we can split this function up into three? DisabledField, StartTime and Endtime? IMO it's a bit messy to read. And "isDisabled" leads to only the RestrictionDisabledField while reading the code.BackendLayoutRenderer.php:77Why not use named arguments here?BackendLayoutRenderer.php:170Why not use named arguments here?BackendLayoutRenderer.php:224Why not use named arguments here?RenderContentElementPreviewViewHelper.php:75Why not use named arguments here? -
Oli Bartsch commented on patch set 11 10/28/25, 09:38
GridColumnItem.php:46Are we going back in time? :DRenderContentElementPreviewViewHelper.php:75ReplyBecause this is not a DTO. -
Oli Bartsch commented on patch set 11 V -1 10/28/25, 09:56
BackendLayoutRenderer.php:77ReplyDoneBackendLayoutRenderer.php:170ReplyDoneBackendLayoutRenderer.php:224ReplyDoneFormPagePreviewRenderer.php:67$flexFormData is always empty -
Oli Bartsch uploaded patch set 12
V +110/28/25, 10:43 -
core-ci voted on patch set 12 V +1 10/28/25, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87792
-
Oli Bartsch uploaded patch set 13
V +110/28/25, 10:54 -
Oli Bartsch commented on patch set 13 CR +1 V +1 10/28/25, 11:03
GridColumnItem.php:46ReplyDoneFormPagePreviewRenderer.php:67ReplyDone -
core-ci voted on patch set 13 V +1 10/28/25, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87795
-
Benni Mack commented on patch set 13 10/28/25, 11:06
GridColumnItem.php:234ReplyI agree, however, I'd like to tackle this separately as this might have more impact in the templates. -
Matthias Vogel voted on patch set 13 CR +1 10/28/25, 12:56
-
Jochen Roth voted on patch set 13 CR +1 V +1 10/28/25, 13:53
-
Benni Mack voted on patch set 13 CR +2 V +2 10/28/25, 14:24
-
Benni Mack merged patch set 14 10/28/25, 14:24
-
Lina Wolf commented on patch set 14 11/02/25, 06:24
Unresolved
Please review the documentation: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/6162 -
Nikita Hovratov commented on patch set 14 02/10/26, 15:04
GridColumnItem.php:370Unresolved`$this->record->getRecordType()` can return null for preview of records without a type field.
StandardContentPreviewRenderer.php:126