Review main Merged Breaking

88519[!!!][TASK] Use Record API in Page Module Preview Rendering

Benni Mack CR +2 V +2 Hard +333 −148 updated 02/13/26, 09:25

Commit message

This change uses Record API in the Page Module when
previewing content elements and other records.

This way, we can now utilize all the record API
magic in the preview renderers - which means in Fluid
directly, without resolving a lot of parts ourselves.

As this might affect extension authors that utilize
Backend Previews, this change is marked as breaking.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 2841

Show 916 earlier messages
  1. Benni Mack uploaded patch set 1 03/06/25, 23:44

  2. core-ci voted on patch set 1 V -1 03/06/25, 23:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75255

  3. Benni Mack marked it work in progress 03/22/25, 12:35

  4. Oli Bartsch uploaded patch set 2 V -1 04/15/25, 14:09

  5. core-ci voted on patch set 2 V -1 04/15/25, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77765

  6. Oli Bartsch uploaded patch set 3 V -1 04/16/25, 08:31

  7. core-ci voted on patch set 3 V +1 04/16/25, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77812

  8. Oli Bartsch uploaded patch set 4 V +1 04/16/25, 09:48

  9. core-ci voted on patch set 4 V +1 04/16/25, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77823

  10. Benni Mack uploaded patch set 5 V +1 07/24/25, 09:00

  11. core-ci voted on patch set 5 V -1 07/24/25, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82226

  12. Benni Mack uploaded patch set 6 V -1 10/13/25, 07:52

  13. core-ci voted on patch set 6 V -1 10/13/25, 08:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86521

  14. Matthias Vogel uploaded patch set 7 V -1 10/27/25, 11:03

  15. core-ci voted on patch set 7 V -1 10/27/25, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87636

  16. Matthias Vogel uploaded patch set 8 V -1 10/27/25, 11:13

  1. core-ci voted on patch set 8 V -1 10/27/25, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87638

  2. Matthias Vogel uploaded patch set 9 V -1 10/27/25, 11:54

  3. core-ci voted on patch set 9 V -1 10/27/25, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87643

  4. Matthias Vogel uploaded patch set 10 V -1 10/27/25, 12:29

  5. core-ci voted on patch set 10 V +1 10/27/25, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87647

  6. Benni Mack commented on patch set 10 10/27/25, 16:17

    StandardContentPreviewRenderer.php:126

    I'd love to have these in separate classes at some point

    StandardContentPreviewRenderer.php:372

    I think this might be used by others (just thinking out loud)

    PageContentPreviewRenderingEvent.php:48

    that's breaking IMHO

    Record.html:9

    the info that the item.record is now a record object, is important to know for externals
  7. Benni Mack uploaded patch set 11 V +1 10/27/25, 16:43

  8. Benni Mack marked it ready for review 10/27/25, 16:53

  9. Benni Mack commented on patch set 11 10/27/25, 16:53

    StandardContentPreviewRenderer.php:126 Reply

    Done

    StandardContentPreviewRenderer.php:372 Reply

    Done

    PageContentPreviewRenderingEvent.php:48 Reply

    Done

    Record.html:9 Reply

    Done
  10. core-ci voted on patch set 11 V +1 10/27/25, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87686

  11. Sven Liebert commented on patch set 11 10/27/25, 20:21

    GridColumnItem.php:234

    Maybe we can split this function up into three? DisabledField, StartTime and Endtime? IMO it's a bit messy to read. And "isDisabled" leads to only the RestrictionDisabledField while reading the code.

    BackendLayoutRenderer.php:77

    Why not use named arguments here?

    BackendLayoutRenderer.php:170

    Why not use named arguments here?

    BackendLayoutRenderer.php:224

    Why not use named arguments here?

    RenderContentElementPreviewViewHelper.php:75

    Why not use named arguments here?
  12. Oli Bartsch commented on patch set 11 10/28/25, 09:38

    GridColumnItem.php:46

    Are we going back in time? :D

    RenderContentElementPreviewViewHelper.php:75 Reply

    Because this is not a DTO.
  13. Oli Bartsch commented on patch set 11 V -1 10/28/25, 09:56

    BackendLayoutRenderer.php:77 Reply

    Done

    BackendLayoutRenderer.php:170 Reply

    Done

    BackendLayoutRenderer.php:224 Reply

    Done

    FormPagePreviewRenderer.php:67

    $flexFormData is always empty
  14. Oli Bartsch uploaded patch set 12 V +1 10/28/25, 10:43

  15. core-ci voted on patch set 12 V +1 10/28/25, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87792

  16. Oli Bartsch uploaded patch set 13 V +1 10/28/25, 10:54

  17. Oli Bartsch commented on patch set 13 CR +1 V +1 10/28/25, 11:03

    GridColumnItem.php:46 Reply

    Done

    FormPagePreviewRenderer.php:67 Reply

    Done
  18. core-ci voted on patch set 13 V +1 10/28/25, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87795

  19. Benni Mack commented on patch set 13 10/28/25, 11:06

    GridColumnItem.php:234 Reply

    I agree, however, I'd like to tackle this separately as this might have more impact in the templates.
  20. Matthias Vogel voted on patch set 13 CR +1 10/28/25, 12:56

  21. Jochen Roth voted on patch set 13 CR +1 V +1 10/28/25, 13:53

  22. Benni Mack voted on patch set 13 CR +2 V +2 10/28/25, 14:24

  23. Benni Mack merged patch set 14 10/28/25, 14:24

  24. Lina Wolf commented on patch set 14 11/02/25, 06:24

  25. Nikita Hovratov commented on patch set 14 02/10/26, 15:04

    GridColumnItem.php:370 Unresolved

    `$this->record->getRecordType()` can return null for preview of records without a type field.