Review main Merged

88522[BUGFIX] Add missing integer casting to ImageProcessing minHeight case

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 03/07/25, 08:24

Commit message

With the refactoring in #106094 one case was overlooked to be adapted.

This patch also casts `$options['minHeight']` to an integer,
in case due to specific operations yielded float values.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Simon Praetorius +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Simon Praetorius +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 56

  1. Garvin Hicking uploaded patch set 1 03/07/25, 08:06

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 03/07/25, 08:10

  3. Simon Praetorius voted on patch set 1 CR +1 V +1 03/07/25, 08:10

  4. Garvin Hicking voted on patch set 1 CR +2 V +2 03/07/25, 08:12

  5. core-ci voted on patch set 1 V +1 03/07/25, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75272

  6. Garvin Hicking merged patch set 2 03/07/25, 08:24