Review main Merged

8853[FEATURE] Reports interface standardize

Felix Kopp CR +2 V +2 Easy +14 −15 updated 06/03/13, 20:49

Commit message

Move extension name from docHeader function menu to module header.
Standardize font size and margins.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1
  • Verified V +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1

Files 2

Review log 11

  1. Ingo Renner commented on patch set 1 02/13/12, 08:23

    (1 inline comment) see, comment. I also don't know what's wrong about it...
  2. Philipp Gampe commented on patch set 1 02/13/12, 08:23

    Keep in mind that the text might be different in other languages. Also there could be a help text if you hover the word "Report:". This is how it should be done. We do not what to have question marks in the BE any more. It might be obvious to you that you have to select reports here, but it is not to. Throughout the backend you have various different dropdowns and not all serve as submenu/function menu.
    Resolves (see comment in other patchset).

    index.php:129

    I disagree. I would like to keep this information.
  3. Philipp Gampe commented on patch set 1 02/13/12, 08:23

    (2 inline comments) See comments. Why do you want to remove an useful user guidance?
  4. Felix Kopp commented on patch set 1 02/13/12, 08:23

    Guys, thank you very much for you immediate feedback!! I thought that this text is not displayed in any other standard backend module - reports has this indication and there is no reason for displaying the module in which the user currenty is. An other issue I have been working on is concerning the question mark icons. There could / should, would be in front of the function menu drop down to give more detailed description. But just the text does not improve guidance in my opinion. Rather reports indicates that reports can be selected within the drop down. That is misleading.
  5. Tolleiv Nietsch commented on patch set 2 02/13/12, 08:23

    Verified; Looks good to me, but someone else must approve
  6. Felix Kopp uploaded patch set 2 02/13/12, 08:23

  7. Felix Kopp commented on patch set 2 02/13/12, 08:23

    After thinking about this for some more time I figured out that the text should be removed but moved. Most modules now received an unique header-title (see http://forge.typo3.org/issues/30263). Now Reports also gets a h2 module title.
  8. Mr. Jenkins commented on patch set 1 02/13/12, 08:23

  9. Mr. Jenkins commented on patch set 2 02/13/12, 08:23

  10. Steffen Ritter commented on patch set 2 V 0 02/13/12, 08:23

    by team member; Looks good to me, approved
  11. Steffen Ritter merged patch set 2 02/13/12, 08:23