Review main Merged

88530[BUGFIX] Workspaces: calculate paging on correct data structure

Andreas Kienast CR +2 V +2 Easy +13 −8 updated 03/10/25, 10:34

Commit message

The method `GridService->calculateStartWithCollections()` relies on
`$this->dataArray` having numeric indices, which is not the case at this
point. The method is called by `GridService->getDataArray()`, which takes
care of this, unfortunately too late.

The key conversion is now done as the beginning of the method, fixing
the pagination.

As a drive-by fix, the pagination component is now properly rendered
after filling the workspace table with new data.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Tina Westner +1
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Tina Westner +1
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Andreas Kienast uploaded patch set 1 03/07/25, 13:45

  2. Andreas Kienast commented on patch set 1 03/07/25, 13:47

    Unresolved

    Note: the web component does not exist in v12, that fix can be omitted then.
  3. Andreas Kienast uploaded patch set 2 03/07/25, 13:48

  4. core-ci voted on patch set 1 V +1 03/07/25, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75303

  5. core-ci voted on patch set 2 V +1 03/07/25, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75304

  6. Tina Westner voted on patch set 2 CR +1 V +1 03/07/25, 14:37

  7. Markus Klein voted on patch set 2 CR +1 V +1 03/10/25, 07:42

  8. Andreas Kienast voted on patch set 2 CR +2 V +2 03/10/25, 10:03

  9. Benni Mack voted on patch set 2 CR +1 V +1 03/10/25, 10:33

  10. Andreas Kienast merged patch set 3 03/10/25, 10:34