Review main Abandoned

88531[TASK] Replace clean-css with cssnano

Benjamin Franzke CR 0 V 0 Nightmare +4070 −4620 updated 03/22/25, 16:04

Commit message

Replace clean-css with cssnano, which is a native postcss plugin
that can operate on the postcss CSS AST directly, without the need
for an own CSS parser implementation.
This means that this plugins is less likely to miss support for new
CSS functionality like container queries (which clean-css – in the
version pulled in by postcss-clean – does not yet support).

Since cssnano requires asynchronous execution, minify-html-literals
is wrapped to support an asynchronous css minification callback.

Commands executed:
  grep -rl clean-css Build/Sources | xargs sed -i '/clean-css/d'
  npm remove postcss-clean
  npm remove rollup-plugin-postcss
  npm install --save-dev cssnano
  # Update to depend on cssnano v7 instead of v6
  npm install --save-dev @ckeditor/ckeditor5-dev-utils@^46
  # Depend on postcss directly, as we use it's API in grunt and rollup
  npm install --save-dev postcss

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 52

Show 32 more files

Review log 1119

  1. Benjamin Franzke uploaded patch set 1 03/07/25, 14:06

  2. core-ci voted on patch set 1 V +1 03/07/25, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75305

  3. Benjamin Franzke uploaded patch set 2 V +1 03/07/25, 20:00

  4. core-ci voted on patch set 2 V +1 03/07/25, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75323

  5. Benjamin Franzke uploaded patch set 3 V +1 03/07/25, 20:38

  6. core-ci voted on patch set 3 V +1 03/07/25, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75325

  7. Benjamin Franzke uploaded patch set 4 V +1 03/07/25, 22:35

  8. core-ci voted on patch set 4 V +1 03/07/25, 22:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75327

  9. Benjamin Franzke uploaded patch set 5 V +1 03/07/25, 22:58

  10. core-ci voted on patch set 5 V +1 03/07/25, 23:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75328

  11. Benjamin Franzke uploaded patch set 6 V +1 03/11/25, 08:12

  12. Benjamin Franzke uploaded patch set 7 03/11/25, 08:29

  13. core-ci voted on patch set 7 V +1 03/11/25, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75465

  14. Benjamin Franzke uploaded patch set 8 V +1 03/11/25, 11:17

  15. core-ci voted on patch set 8 V +1 03/11/25, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75474

  16. Benjamin Franzke uploaded patch set 9 V +1 03/11/25, 11:24

  17. core-ci voted on patch set 9 V +1 03/11/25, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75475

  18. Benjamin Franzke marked it work in progress 03/11/25, 14:06

  19. Benjamin Franzke abandoned the change 03/22/25, 16:04

    merged into parent in relation chain: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88272